Skip to content

Icons Rebrand - Sass Variable Names Error #1170

@amagana8

Description

@amagana8

Issue Type

Bug Report

Component or Pattern Affected

Library Variables

Expected Behavior

Expect there to be no errors that prevent compiling in the library.

Current Behavior

After running yarn add @momentum-ui/icons-rebrand I get a compile error about variable declarations. The SCSS file in question is from this library.
Screen Shot 2022-03-04 at 9 37 41 AM

Possible Solution

Rename the variables to not include the % character.

Steps to Reproduce (for bugs)

Starting from a react project that did not previously use the @momentum-ui/icons-rebrand package.

  1. Run yarn add @momentum-ui/icons-rebrand
  2. Run yarn start
  3. Failed to compile error will appear with a Sass error.

Context

I was trying to add the icons-rebrand project to my team's project but am unable to do as adding it currently breaks the website.

Your Environment

  • Library: icons-rebrand
  • Version used: 1.26.0
  • Browser Name and version: Chrome 97.0.4692.99
  • Operating System and version: macOS 12.2.1
  • Link to your project: N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions