Skip to content

Commit a8ed3cf

Browse files
authored
Update pysdk version to 1.2.1, simplify app payload creation by removing unused parameters, and adjust related async and sync client methods. Update tests to reflect changes in payload structure. (#358)
1 parent 8902bc8 commit a8ed3cf

File tree

7 files changed

+14
-94
lines changed

7 files changed

+14
-94
lines changed

sdks/python/morphik/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@
1414
"DocumentQueryResponse",
1515
]
1616

17-
__version__ = "1.2.0"
17+
__version__ = "1.2.1"

sdks/python/morphik/_shared.py

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -95,27 +95,8 @@ def build_rotate_app_params(
9595
return params
9696

9797

98-
def build_create_app_payload(
99-
*,
100-
name: str,
101-
app_id: Optional[str],
102-
user_id: Optional[str],
103-
expiry_days: Optional[int],
104-
org_id: Optional[str],
105-
created_by_user_id: Optional[str],
106-
) -> Dict[str, Any]:
107-
payload: Dict[str, Any] = {"name": name}
108-
if app_id is not None:
109-
payload["app_id"] = app_id
110-
if user_id is not None:
111-
payload["user_id"] = user_id
112-
if expiry_days is not None:
113-
payload["expiry_days"] = expiry_days
114-
if org_id is not None:
115-
payload["org_id"] = org_id
116-
if created_by_user_id is not None:
117-
payload["created_by_user_id"] = created_by_user_id
118-
return payload
98+
def build_create_app_payload(*, name: str) -> Dict[str, Any]:
99+
return {"name": name}
119100

120101

121102
def build_requeue_payload(

sdks/python/morphik/async_.py

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1941,42 +1941,18 @@ async def create_app(
19411941
self,
19421942
*,
19431943
name: str,
1944-
app_id: Optional[str] = None,
1945-
user_id: Optional[str] = None,
1946-
expiry_days: Optional[int] = None,
1947-
org_id: Optional[str] = None,
1948-
created_by_user_id: Optional[str] = None,
19491944
) -> Dict[str, str]:
19501945
"""Create a cloud app and return its authenticated URI (async)."""
1951-
payload = build_create_app_payload(
1952-
name=name,
1953-
app_id=app_id,
1954-
user_id=user_id,
1955-
expiry_days=expiry_days,
1956-
org_id=org_id,
1957-
created_by_user_id=created_by_user_id,
1958-
)
1946+
payload = build_create_app_payload(name=name)
19591947
return await self._request("POST", "cloud/generate_uri", data=payload)
19601948

19611949
async def generate_cloud_uri(
19621950
self,
19631951
*,
19641952
name: str,
1965-
app_id: Optional[str] = None,
1966-
user_id: Optional[str] = None,
1967-
expiry_days: Optional[int] = None,
1968-
org_id: Optional[str] = None,
1969-
created_by_user_id: Optional[str] = None,
19701953
) -> Dict[str, str]:
19711954
"""Deprecated alias for create_app (async)."""
1972-
return await self.create_app(
1973-
name=name,
1974-
app_id=app_id,
1975-
user_id=user_id,
1976-
expiry_days=expiry_days,
1977-
org_id=org_id,
1978-
created_by_user_id=created_by_user_id,
1979-
)
1955+
return await self.create_app(name=name)
19801956

19811957
async def requeue_ingestion_jobs(
19821958
self,

sdks/python/morphik/sync.py

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1978,42 +1978,18 @@ def create_app(
19781978
self,
19791979
*,
19801980
name: str,
1981-
app_id: Optional[str] = None,
1982-
user_id: Optional[str] = None,
1983-
expiry_days: Optional[int] = None,
1984-
org_id: Optional[str] = None,
1985-
created_by_user_id: Optional[str] = None,
19861981
) -> Dict[str, str]:
19871982
"""Create a cloud app and return its authenticated URI."""
1988-
payload = build_create_app_payload(
1989-
name=name,
1990-
app_id=app_id,
1991-
user_id=user_id,
1992-
expiry_days=expiry_days,
1993-
org_id=org_id,
1994-
created_by_user_id=created_by_user_id,
1995-
)
1983+
payload = build_create_app_payload(name=name)
19961984
return self._request("POST", "cloud/generate_uri", data=payload)
19971985

19981986
def generate_cloud_uri(
19991987
self,
20001988
*,
20011989
name: str,
2002-
app_id: Optional[str] = None,
2003-
user_id: Optional[str] = None,
2004-
expiry_days: Optional[int] = None,
2005-
org_id: Optional[str] = None,
2006-
created_by_user_id: Optional[str] = None,
20071990
) -> Dict[str, str]:
20081991
"""Deprecated alias for create_app."""
2009-
return self.create_app(
2010-
name=name,
2011-
app_id=app_id,
2012-
user_id=user_id,
2013-
expiry_days=expiry_days,
2014-
org_id=org_id,
2015-
created_by_user_id=created_by_user_id,
2016-
)
1992+
return self.create_app(name=name)
20171993

20181994
def requeue_ingestion_jobs(
20191995
self,

sdks/python/morphik/tests/test_app_ops.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,10 @@ def test_sync_app_ops_payloads():
101101
assert call["endpoint"] == "apps/rotate_token"
102102
assert call["params"] == {"app_name": "demo", "expiry_days": 10}
103103

104-
client.create_app(name="demo", org_id="org")
104+
client.create_app(name="demo")
105105
call = calls.pop()
106106
assert call["endpoint"] == "cloud/generate_uri"
107-
assert call["data"] == {"name": "demo", "org_id": "org"}
107+
assert call["data"] == {"name": "demo"}
108108

109109
client.requeue_ingestion_jobs(jobs=[RequeueIngestionJob(external_id="doc-1")])
110110
call = calls.pop()
@@ -145,10 +145,10 @@ async def test_async_app_ops_payloads():
145145
assert call["endpoint"] == "apps/rotate_token"
146146
assert call["params"] == {"app_id": "app-1"}
147147

148-
await client.create_app(name="demo", user_id="u1", expiry_days=30)
148+
await client.create_app(name="demo")
149149
call = calls.pop()
150150
assert call["endpoint"] == "cloud/generate_uri"
151-
assert call["data"] == {"name": "demo", "user_id": "u1", "expiry_days": 30}
151+
assert call["data"] == {"name": "demo"}
152152

153153
await client.requeue_ingestion_jobs(include_all=True, statuses=["failed"])
154154
call = calls.pop()

sdks/python/morphik/tests/test_shared_helpers.py

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -70,21 +70,8 @@ def test_build_rotate_app_params_validation():
7070

7171

7272
def test_build_create_app_payload():
73-
payload = build_create_app_payload(
74-
name="app",
75-
app_id="id",
76-
user_id=None,
77-
expiry_days=7,
78-
org_id="org",
79-
created_by_user_id="creator",
80-
)
81-
assert payload == {
82-
"name": "app",
83-
"app_id": "id",
84-
"expiry_days": 7,
85-
"org_id": "org",
86-
"created_by_user_id": "creator",
87-
}
73+
payload = build_create_app_payload(name="app")
74+
assert payload == {"name": "app"}
8875

8976

9077
def test_build_requeue_payload_with_jobs():

sdks/python/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ build-backend = "hatchling.build"
44

55
[project]
66
name = "morphik"
7-
version = "1.2.0"
7+
version = "1.2.1"
88
authors = [
99
{ name = "Morphik", email = "founders@morphik.ai" },
1010
]

0 commit comments

Comments
 (0)