Skip to content

Commit 1e256eb

Browse files
committed
feature(nimbus): Add features page base template and routing.
1 parent 7d6e54b commit 1e256eb

File tree

4 files changed

+34
-0
lines changed

4 files changed

+34
-0
lines changed
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{% extends "experimenter_base.html" %}
2+
3+
{% block content %}
4+
<div id="feature-page" class="bg-body0tertiary py-4">
5+
<div class="container">
6+
</div>
7+
</div>
8+
{% endblock %}

experimenter/experimenter/nimbus_ui/tests/test_views.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3293,3 +3293,10 @@ def test_slug_without_trailing_slash_redirects_to_summary(self):
32933293
response.url,
32943294
reverse("nimbus-ui-detail", kwargs={"slug": experiment.slug}),
32953295
)
3296+
3297+
class TestNimbusFeaturesView(AuthTestCase):
3298+
def test_features_view_renders_template(self):
3299+
NimbusExperimentFactory.create(owner=self.user)
3300+
response = self.client.get(reverse("nimbus-ui-features"))
3301+
self.assertEqual(response.status_code, 200)
3302+
self.assertTemplateUsed(response, "nimbus_experiments/features.html")

experimenter/experimenter/nimbus_ui/urls.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
NimbusExperimentsListTableView,
3131
NimbusExperimentsPromoteToRolloutView,
3232
NimbusExperimentsSidebarCloneView,
33+
NimbusFeaturesView,
3334
OverviewUpdateView,
3435
PreviewToDraftView,
3536
PreviewToReviewView,
@@ -60,6 +61,11 @@
6061
NimbusExperimentsCreateView.as_view(),
6162
name="nimbus-ui-create",
6263
),
64+
re_path(
65+
r"^features/",
66+
NimbusFeaturesView.as_view(),
67+
name="nimbus-ui-features",
68+
),
6369
re_path(
6470
r"^(?P<slug>[\w-]+)[/]?$",
6571
RedirectView.as_view(pattern_name="nimbus-ui-detail", permanent=False),

experimenter/experimenter/nimbus_ui/views.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
from experimenter.experiments.constants import EXTERNAL_URLS, RISK_QUESTIONS
1111
from experimenter.experiments.models import (
1212
NimbusExperiment,
13+
NimbusFeatureConfig
1314
)
1415
from experimenter.nimbus_ui.constants import NimbusUIConstants
1516
from experimenter.nimbus_ui.filtersets import (
@@ -629,6 +630,18 @@ class ResultsView(NimbusExperimentViewMixin, DetailView):
629630
template_name = "nimbus_experiments/results.html"
630631

631632

633+
class NimbusFeaturesView(FilterView):
634+
template_name = "nimbus_experiments/features.html"
635+
filterset_class = NimbusExperimentFilter
636+
context_object_name = "features"
637+
638+
def get_queryset(self):
639+
return (NimbusFeatureConfig.objects
640+
.filter().order_by(
641+
"-name"
642+
)
643+
)
644+
632645
class NimbusExperimentsHomeView(FilterView):
633646
template_name = "nimbus_experiments/home.html"
634647
filterset_class = NimbusExperimentsHomeFilter

0 commit comments

Comments
 (0)