Cloned from
diff --git a/experimenter/experimenter/nimbus_ui/tests/test_forms.py b/experimenter/experimenter/nimbus_ui/tests/test_forms.py
index 82bb3d6ce6..d4bfd91e4d 100644
--- a/experimenter/experimenter/nimbus_ui/tests/test_forms.py
+++ b/experimenter/experimenter/nimbus_ui/tests/test_forms.py
@@ -80,6 +80,7 @@
TagFormSet,
TakeawaysForm,
ToggleArchiveForm,
+ ToggleReviewSlackNotificationsForm,
UnsubscribeForm,
)
from experimenter.openidc.tests.factories import UserFactory
@@ -404,6 +405,54 @@ def test_toggle_unarchive(self):
)
+class TestToggleReviewSlackNotificationsForm(RequestFormTestCase):
+ @parameterized.expand(
+ [
+ (
+ "enable",
+ False,
+ True,
+ "enabled",
+ ),
+ (
+ "disable",
+ True,
+ False,
+ "disabled",
+ ),
+ ]
+ )
+ def test_toggle_slack_notifications(
+ self, _name, initial_value, new_value, expected_status
+ ):
+ experiment = NimbusExperiment.objects.create(
+ owner=self.user,
+ name="Test Experiment",
+ slug="test-experiment",
+ enable_review_slack_notifications=initial_value,
+ )
+
+ data = {
+ "enable_review_slack_notifications": new_value,
+ }
+
+ form = ToggleReviewSlackNotificationsForm(
+ data, instance=experiment, request=self.request
+ )
+ self.assertTrue(form.is_valid())
+
+ updated_experiment = form.save()
+
+ self.assertEqual(updated_experiment.enable_review_slack_notifications, new_value)
+
+ changelog_message = form.get_changelog_message()
+
+ self.assertEqual(
+ changelog_message,
+ f"{self.user} {expected_status} review Slack notifications",
+ )
+
+
class TestQAStatusForm(RequestFormTestCase):
def test_form_updates_qa_fields_and_creates_changelog(self):
experiment = NimbusExperimentFactory.create_with_lifecycle(
@@ -1382,6 +1431,100 @@ def test_approve_update_rollout_form(self):
self.mock_preview_task.assert_called_once_with(countdown=5)
self.mock_allocate_bucket_range.assert_called_once()
+ @parameterized.expand(
+ [
+ (
+ "draft_to_review_skips_slack_when_disabled",
+ DraftToReviewForm,
+ NimbusExperiment.Status.DRAFT,
+ {},
+ False,
+ False,
+ ),
+ (
+ "draft_to_review_sends_slack_when_enabled",
+ DraftToReviewForm,
+ NimbusExperiment.Status.DRAFT,
+ {},
+ True,
+ True,
+ ),
+ (
+ "live_to_update_rollout_skips_slack_when_disabled",
+ LiveToUpdateRolloutForm,
+ NimbusExperiment.Status.LIVE,
+ {"is_rollout": True},
+ False,
+ False,
+ ),
+ (
+ "live_to_update_rollout_sends_slack_when_enabled",
+ LiveToUpdateRolloutForm,
+ NimbusExperiment.Status.LIVE,
+ {"is_rollout": True},
+ True,
+ True,
+ ),
+ (
+ "live_to_end_enrollment_skips_slack_when_disabled",
+ LiveToEndEnrollmentForm,
+ NimbusExperiment.Status.LIVE,
+ {},
+ False,
+ False,
+ ),
+ (
+ "live_to_end_enrollment_sends_slack_when_enabled",
+ LiveToEndEnrollmentForm,
+ NimbusExperiment.Status.LIVE,
+ {},
+ True,
+ True,
+ ),
+ (
+ "live_to_complete_skips_slack_when_disabled",
+ LiveToCompleteForm,
+ NimbusExperiment.Status.LIVE,
+ {},
+ False,
+ False,
+ ),
+ (
+ "live_to_complete_sends_slack_when_enabled",
+ LiveToCompleteForm,
+ NimbusExperiment.Status.LIVE,
+ {},
+ True,
+ True,
+ ),
+ ]
+ )
+ def test_slack_notification_behavior(
+ self,
+ _name,
+ form_class,
+ status,
+ extra_kwargs,
+ enable_slack,
+ should_call_slack,
+ ):
+ experiment = NimbusExperimentFactory.create(
+ status=status,
+ status_next=None,
+ publish_status=NimbusExperiment.PublishStatus.IDLE,
+ enable_review_slack_notifications=enable_slack,
+ **extra_kwargs,
+ )
+ form = form_class(data={}, instance=experiment, request=self.request)
+ self.assertTrue(form.is_valid(), form.errors)
+
+ form.save()
+
+ if should_call_slack:
+ self.mock_slack_task.assert_called_once()
+ else:
+ self.mock_slack_task.assert_not_called()
+
class TestOverviewForm(RequestFormTestCase):
def test_valid_form_saves(self):
diff --git a/experimenter/experimenter/nimbus_ui/tests/test_views.py b/experimenter/experimenter/nimbus_ui/tests/test_views.py
index 1fcce7be41..78165c28ec 100644
--- a/experimenter/experimenter/nimbus_ui/tests/test_views.py
+++ b/experimenter/experimenter/nimbus_ui/tests/test_views.py
@@ -1626,6 +1626,43 @@ def test_toggle_archive_status_to_unarchive(self):
self.assertFalse(updated_experiment.is_archived)
+class TestToggleReviewSlackNotificationsView(AuthTestCase):
+ def setUp(self):
+ super().setUp()
+ self.experiment = NimbusExperiment.objects.create(
+ slug="test-experiment",
+ name="Test Experiment",
+ owner=self.user,
+ enable_review_slack_notifications=True,
+ )
+
+ @parameterized.expand(
+ [
+ ("disable", True, False),
+ ("enable", False, True),
+ ]
+ )
+ def test_toggle_slack_notifications(self, _name, initial_value, new_value):
+ self.experiment.enable_review_slack_notifications = initial_value
+ self.experiment.save()
+
+ response = self.client.post(
+ reverse(
+ "nimbus-ui-toggle-review-slack-notifications",
+ kwargs={"slug": self.experiment.slug},
+ ),
+ {"enable_review_slack_notifications": new_value},
+ )
+ self.assertEqual(response.status_code, 302)
+ self.assertEqual(
+ response.url,
+ reverse("nimbus-ui-detail", kwargs={"slug": self.experiment.slug}),
+ )
+
+ updated_experiment = NimbusExperiment.objects.get(slug=self.experiment.slug)
+ self.assertEqual(updated_experiment.enable_review_slack_notifications, new_value)
+
+
class TestOverviewUpdateView(AuthTestCase):
def test_get_renders_for_draft_experiment(self):
experiment = NimbusExperimentFactory.create_with_lifecycle(
diff --git a/experimenter/experimenter/nimbus_ui/urls.py b/experimenter/experimenter/nimbus_ui/urls.py
index d3d6c233f0..8a3129ff5e 100644
--- a/experimenter/experimenter/nimbus_ui/urls.py
+++ b/experimenter/experimenter/nimbus_ui/urls.py
@@ -51,6 +51,7 @@
TagsManageView,
TakeawaysUpdateView,
ToggleArchiveView,
+ ToggleReviewSlackNotificationsView,
UnsubscribeView,
)
@@ -200,6 +201,11 @@
FeatureUnsubscribeView.as_view(),
name="nimbus-ui-feature-unsubscribe",
),
+ re_path(
+ r"^(?P