Merge pull request #7243 from denyshon/tb-ver-question-details

akatsoulas · web-flow · commit c0bfff6bda8c · 2026-02-11T10:31:16.000+02:00
Set maxlength for the ff_version &amp; tb_version fields
diff --git a/kitsune/questions/forms.py b/kitsune/questions/forms.py
@@ -108,13 +108,14 @@ def __init__(self, product=None, *args, **kwargs):
             self.fields["ff_version"] = forms.CharField(
                 label=FF_VERSION_LABEL,
                 required=False,
+                widget=forms.TextInput(attrs={"maxlength": 30 - len("Firefox ")}),
             )
 
         if "tb_version" in extra_fields:
             self.fields["tb_version"] = forms.CharField(
                 label=TB_VERSION_LABEL,
                 required=False,
-                widget=forms.TextInput(attrs={"placeholder": TB_VERSION_PLACEHOLDER}),
+                widget=forms.TextInput(attrs={"placeholder": TB_VERSION_PLACEHOLDER, "maxlength": 30 - len("Thunderbird ")}),
             )
 
         if "os" in extra_fields:

Original file line number	Diff line number	Diff line change
`@@ -108,13 +108,14 @@ def __init__(self, product=None, args, *kwargs):`
`108`	`108`	`self.fields["ff_version"] = forms.CharField(`
`109`	`109`	`label=FF_VERSION_LABEL,`
`110`	`110`	`required=False,`
	`111`	`+ widget=forms.TextInput(attrs={"maxlength": 30 - len("Firefox ")}),`
`111`	`112`	`)`
`112`	`113`
`113`	`114`	`if "tb_version" in extra_fields:`
`114`	`115`	`self.fields["tb_version"] = forms.CharField(`
`115`	`116`	`label=TB_VERSION_LABEL,`
`116`	`117`	`required=False,`
`117`		`- widget=forms.TextInput(attrs={"placeholder": TB_VERSION_PLACEHOLDER}),`
	`118`	`+ widget=forms.TextInput(attrs={"placeholder": TB_VERSION_PLACEHOLDER, "maxlength": 30 - len("Thunderbird ")}),`
`118`	`119`	`)`
`119`	`120`
`120`	`121`	`if "os" in extra_fields:`