Skip to content

Fix: Collapsible Table demo row skipping with VoiceOver #47653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seomsoo wants to merge 2 commits into
base: master
Choose a base branch
from
+20 −4
Open

Fix: Collapsible Table demo row skipping with VoiceOver #47653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f526f71
fix(docs): prevent VoiceOver from skipping collapsible table rows
seomsoo Jan 18, 2026
317c748
fix(docs): avoid visual regression while fixing VoiceOver row skipping
seomsoo Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions docs/data/material/components/table/CollapsibleTable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,15 @@ function createData(name, calories, fat, carbs, protein, price) {
function Row(props) {
const { row } = props;
const [open, setOpen] = React.useState(false);
const [exited, setExited] = React.useState(true);

return (
<React.Fragment>
<TableRow sx={{ '& > *': { borderBottom: 'unset' } }}>
<TableCell>
<IconButton
aria-label="expand row"
aria-expanded={open}
size="small"
onClick={() => setOpen(!open)}
>
Expand All @@ -61,9 +63,15 @@ function Row(props) {
<TableCell align="right">{row.carbs}</TableCell>
<TableCell align="right">{row.protein}</TableCell>
</TableRow>
<TableRow>
<TableRow aria-hidden={!open && exited ? true : undefined}>
<TableCell style={{ paddingBottom: 0, paddingTop: 0 }} colSpan={6}>
<Collapse in={open} timeout="auto" unmountOnExit>
<Collapse
in={open}
timeout="auto"
unmountOnExit
onEnter={() => setExited(false)}
onExited={() => setExited(true)}
>
<Box sx={{ margin: 1 }}>
<Typography variant="h6" gutterBottom component="div">
History
Expand Down
12 changes: 10 additions & 2 deletions docs/data/material/components/table/CollapsibleTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,13 +46,15 @@ function createData(
function Row(props: { row: ReturnType<typeof createData> }) {
const { row } = props;
const [open, setOpen] = React.useState(false);
const [exited, setExited] = React.useState(true);

return (
<React.Fragment>
<TableRow sx={{ '& > *': { borderBottom: 'unset' } }}>
<TableCell>
<IconButton
aria-label="expand row"
aria-expanded={open}
size="small"
onClick={() => setOpen(!open)}
>
Expand All @@ -67,9 +69,15 @@ function Row(props: { row: ReturnType<typeof createData> }) {
<TableCell align="right">{row.carbs}</TableCell>
<TableCell align="right">{row.protein}</TableCell>
</TableRow>
<TableRow>
<TableRow aria-hidden={!open && exited ? true : undefined}>
<TableCell style={{ paddingBottom: 0, paddingTop: 0 }} colSpan={6}>
<Collapse in={open} timeout="auto" unmountOnExit>
<Collapse
in={open}
timeout="auto"
unmountOnExit
onEnter={() => setExited(false)}
onExited={() => setExited(true)}
>
<Box sx={{ margin: 1 }}>
<Typography variant="h6" gutterBottom component="div">
History
Expand Down
Loading