Skip to content

[error-handling] Generic Exception in check_result.py validation #23

@wody34

Description

@wody34

📁 Location

  • File: tests/test_nest_MPI_threading/check_result.py:465-469
  • Category: error-handling
  • Severity: high
  • Hashes: dc86e9e64f8e, 21829b74c185, e452362de3aa

🔍 Problem

3 instances of generic Exception with vague messages:

  • Line 465: raise Exception("Miss nb recorder")
  • Line 467: raise Exception("Miss nb spike generator")
  • Line 469: raise Exception("Miss nb current generator")

💡 Fix

# Before
raise Exception("Miss nb recorder")

# After
raise ValueError(
    f"Invalid recorder count: {nb_mpi_recorder} "
    f"not divisible by {nb_element}"
)

🧪 TDD Evidence

Test file: tests/evidence/test_error_handling_check_result.py

  • 3 tests verifying proper ValueError with descriptive messages
  • All tests PASS with correct pattern
tests/evidence/test_error_handling_check_result.py::TestCheckResultErrorHandling::test_recorder_count_validation_raises_value_error PASSED
tests/evidence/test_error_handling_check_result.py::TestCheckResultErrorHandling::test_spike_generator_count_validation_raises_value_error PASSED
tests/evidence/test_error_handling_check_result.py::TestCheckResultErrorHandling::test_current_generator_count_validation_raises_value_error PASSED

Run: 2026-02-05-1228 | Auto-generated by UltraQA

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions