Passing parameters to function navit_set_attr

[adevoss]

Hi everyone,

In file /usr/src/navit/navit/gui/internal/gui_internal.c there is my new function:

static void gui_internal_cmd_set_active_voice_profile(struct gui_priv *this, struct widget *wm, void *data) {
    struct voice_and_profilename *vapn = data;
 
    // TODO Voice Change the active profile
    dbg(lvl_debug, "----------------------------------- setting speech to '%s' (%s) with navit_set_attr", vapn->profilename, vapn->speech);
    navit_set_attr(this->nav, &vapn->speech);
    dbg(lvl_debug, "Changed voice to '%s'", vapn->profilename);

    gui_internal_prune_menu_count(this, 1, 0);
    gui_internal_menu_voice_settings(this);
}

File /usr/src/navit/navit/navit.c

int navit_set_attr(struct navit *this_, struct attr *attr) {
    dbg(lvl_debug, "-------------------------------- calling generic setter method for attribute type %s", attr_to_name(attr->type))
    return navit_set_attr_do(this_, attr, 0);
}           

Debug log:

debug:gui_internal:gui_internal_cmd_set_active_voice_profile:----------------------------------- setting speech to 'Dutch female' ( <88>�<89>^?) with navit_set_attr
debug:navit:navit_set_attr:-------------------------------- calling generic setter method for attribute type (null)

Why the data is lost when navit_set_attr is called? The parameters have values when calling navit_set_attr but not in the function navit_set_attr itelf.
In the logfile I expect type (speech) instead of type (null).
This is the last piece I have to figure out for PR #1299

[christf]

Hi, sorry for the delay. When I build 1299, the build breaks:

/home/christof/Programmierung/navit/navit/gui/internal/gui_internal.c:1951:31: error: passing argument 2 of ‘navit_set_attr’ from incompatible pointer type [-Wincompatible-pointer-types]
 1951 |     navit_set_attr(this->nav, &vapn->speech);
      |                               ^~~~~~~~~~~~~
      |                               |
      |                               struct speech **
In file included from /home/christof/Programmierung/navit/navit/gui/internal/gui_internal.c:49:
/home/christof/Programmierung/navit/navit/navit.h:108:54: note: expected ‘struct attr *’ but argument is of type ‘struct speech **’
  108 | int navit_set_attr(struct navit *this_, struct attr *attr);
      |                                         ~~~~~~~~~~~~~^~~~

The incompatible pointer types easily could cause empty values.

[jkoan]

As @christf pointed out the compiler already wants you that the types are not compatible. You are passing a voice struct where you need to pass a attr struct. In fc009f7 I fixed exactly this by using a intermediate attr which gets the right type and the voice data you already wanted to set.

Why does it look like the data is lost?
Inside the set attr function thers a switch on the type of the attr, which is null because it's not an attr at all. Not the data is null, but it's type because the data is wrong in the first place

[adevoss]

@jkoan Thanks for solving this last step.