Skip to content

Commit 5d32870

Browse files
authored
Merge pull request #912 from Amoghrd/netobserv-1981
NETOBSERV-1981: Fix Exporters form view
2 parents 8828735 + dddd2a6 commit 5d32870

File tree

6 files changed

+23
-5
lines changed

6 files changed

+23
-5
lines changed

apis/flowcollector/v1beta2/flowcollector_types.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -410,11 +410,11 @@ type FlowCollectorEBPF struct {
410410
type FlowCollectorKafka struct {
411411
// Important: Run "make generate" to regenerate code after modifying this file
412412

413-
//+kubebuilder:default:=""
413+
// +kubebuilder:default:=""
414414
// Address of the Kafka server
415415
Address string `json:"address"`
416416

417-
//+kubebuilder:default:=""
417+
// +kubebuilder:default:=""
418418
// Kafka topic to use. It must exist. NetObserv does not create it.
419419
Topic string `json:"topic"`
420420

@@ -428,11 +428,12 @@ type FlowCollectorKafka struct {
428428
}
429429

430430
type FlowCollectorIPFIXReceiver struct {
431-
//+kubebuilder:default:=""
431+
// +kubebuilder:default:=""
432432
// Address of the IPFIX external receiver.
433433
TargetHost string `json:"targetHost"`
434434

435435
// Port for the IPFIX external receiver.
436+
// +kubebuilder:default:=4739
436437
TargetPort int `json:"targetPort"`
437438

438439
// Transport protocol (`TCP` or `UDP`) to be used for the IPFIX connection, defaults to `TCP`.
@@ -444,13 +445,13 @@ type FlowCollectorIPFIXReceiver struct {
444445

445446
type FlowCollectorOpenTelemetryLogs struct {
446447
// Set `enable` to `true` to send logs to an OpenTelemetry receiver.
447-
//+kubebuilder:default:=true
448+
// +kubebuilder:default:=true
448449
Enable *bool `json:"enable,omitempty"`
449450
}
450451

451452
type FlowCollectorOpenTelemetryMetrics struct {
452453
// Set `enable` to `true` to send metrics to an OpenTelemetry receiver.
453-
//+kubebuilder:default:=true
454+
// +kubebuilder:default:=true
454455
Enable *bool `json:"enable,omitempty"`
455456

456457
// Specify how often metrics are sent to a collector.
@@ -472,6 +473,7 @@ type FlowCollectorOpenTelemetry struct {
472473
TargetHost string `json:"targetHost"`
473474

474475
// Port for the OpenTelemetry receiver.
476+
// +kubebuilder:default:=4317
475477
TargetPort int `json:"targetPort"`
476478

477479
// Protocol of the OpenTelemetry connection. The available options are `http` and `grpc`.

bundle/manifests/flows.netobserv.io_flowcollectors.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6067,6 +6067,7 @@ spec:
60676067
description: Address of the IPFIX external receiver.
60686068
type: string
60696069
targetPort:
6070+
default: 4739
60706071
description: Port for the IPFIX external receiver.
60716072
type: integer
60726073
transport:
@@ -6303,6 +6304,7 @@ spec:
63036304
description: Address of the OpenTelemetry receiver.
63046305
type: string
63056306
targetPort:
6307+
default: 4317
63066308
description: Port for the OpenTelemetry receiver.
63076309
type: integer
63086310
tls:

bundle/manifests/netobserv-operator.clusterserviceversion.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -732,6 +732,10 @@ spec:
732732
path: exporters[0].kafka
733733
x-descriptors:
734734
- urn:alm:descriptor:com.tectonic.ui:fieldDependency:exporters.type:Kafka
735+
- displayName: OpenTelemetry configuration
736+
path: exporters[0].openTelemetry
737+
x-descriptors:
738+
- urn:alm:descriptor:com.tectonic.ui:fieldDependency:exporters.type:OpenTelemetry
735739
- displayName: Exclude interfaces
736740
path: agent.ebpf.excludeInterfaces
737741
- displayName: Features

config/crd/bases/flows.netobserv.io_flowcollectors.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5616,6 +5616,7 @@ spec:
56165616
description: Address of the IPFIX external receiver.
56175617
type: string
56185618
targetPort:
5619+
default: 4739
56195620
description: Port for the IPFIX external receiver.
56205621
type: integer
56215622
transport:
@@ -5817,6 +5818,7 @@ spec:
58175818
description: Address of the OpenTelemetry receiver.
58185819
type: string
58195820
targetPort:
5821+
default: 4317
58205822
description: Port for the OpenTelemetry receiver.
58215823
type: integer
58225824
tls:

config/csv/bases/netobserv-operator.clusterserviceversion.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,10 @@ spec:
281281
path: exporters[0].kafka
282282
x-descriptors:
283283
- "urn:alm:descriptor:com.tectonic.ui:fieldDependency:exporters.type:Kafka"
284+
- displayName: OpenTelemetry configuration
285+
path: exporters[0].openTelemetry
286+
x-descriptors:
287+
- "urn:alm:descriptor:com.tectonic.ui:fieldDependency:exporters.type:OpenTelemetry"
284288
statusDescriptors:
285289
- displayName: Namespace
286290
description: Namespace where console plugin and flowlogs-pipeline have been deployed.

docs/FlowCollector.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12056,6 +12056,8 @@ IPFIX configuration, such as the IP address and port to send enriched IPFIX flow
1205612056
<td>integer</td>
1205712057
<td>
1205812058
Port for the IPFIX external receiver.<br/>
12059+
<br/>
12060+
<i>Default</i>: 4739<br/>
1205912061
</td>
1206012062
<td>true</td>
1206112063
</tr><tr>
@@ -12476,6 +12478,8 @@ OpenTelemetry configuration, such as the IP address and port to send enriched lo
1247612478
<td>integer</td>
1247712479
<td>
1247812480
Port for the OpenTelemetry receiver.<br/>
12481+
<br/>
12482+
<i>Default</i>: 4317<br/>
1247912483
</td>
1248012484
<td>true</td>
1248112485
</tr><tr>

0 commit comments

Comments
 (0)