implement allow download and sync

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

Author: alperozturk96

app/src/main/java/it/niedermann/owncloud/notes/share/NoteShareActivity.java

@@ -859,14 +859,22 @@ public void setPasswordToShare(@NotNull OCShare share, @Nullable String password
 
         executorService.submit(() -> {
             {
+                boolean isDownloadAndAllowsSyncEnabled = repository.isAllowDownloadAndSync(share);
+
+                String attributes = UpdateShareRequest.Companion.createAttributes(
+                    repository.getCapabilities(),
+                    isDownloadAndAllowsSyncEnabled,
+                    share.getShareType()
+                );
+
                 final var requestBody = new UpdateShareRequest(
                     share.getPermissions(),
                     password,
                     share.getNote(),
                     share.getLabel(),
                     DateUtil.INSTANCE.getExpirationDate(share.getExpirationDate()),
                     Boolean.toString(share.isHideFileDownload()),
-                    ""
+                    attributes
                 );
                 final var result = repository.updateShare(share.getId(), requestBody);
 

app/src/main/java/it/niedermann/owncloud/notes/share/NoteShareDetailActivity.kt

@@ -27,8 +27,6 @@ import it.niedermann.owncloud.notes.persistence.isSuccess
 import it.niedermann.owncloud.notes.share.dialog.ExpirationDatePickerDialogFragment
 import it.niedermann.owncloud.notes.share.helper.SharePermissionManager
 import it.niedermann.owncloud.notes.share.model.QuickPermissionType
-import it.niedermann.owncloud.notes.share.model.ShareAttributesV1
-import it.niedermann.owncloud.notes.share.model.ShareAttributesV2
 import it.niedermann.owncloud.notes.share.model.UpdateShareRequest
 import it.niedermann.owncloud.notes.share.repository.ShareRepository
 import it.niedermann.owncloud.notes.shared.util.DisplayUtils
@@ -332,18 +330,7 @@ class NoteShareDetailActivity :
             allowDownloadAndSync.visibility = View.VISIBLE
 
             share?.let {
-                val entity = repository.getShareByPathAndDisplayName(it)
-                val attributes = entity?.attributes ?: return
-                share?.attributes = attributes
-
-                val capabilities = repository.getCapabilities()
-                val shouldUseShareAttributesV2 = (capabilities.nextcloudMajorVersion?.toInt() ?: 0) >= 30
-                val isDownloadAndAllowsSyncEnabled = if (shouldUseShareAttributesV2) {
-                    ShareAttributesV2.getAttributes(attributes).first().value
-                } else {
-                    ShareAttributesV1.getAttributes(attributes).first().enabled
-                }
-
+                val isDownloadAndAllowsSyncEnabled = repository.isAllowDownloadAndSync(it)
                 binding.allowDownloadAndSync.isChecked = isDownloadAndAllowsSyncEnabled
             }
         }

app/src/main/java/it/niedermann/owncloud/notes/share/model/UpdateShareRequest.kt

@@ -43,8 +43,8 @@ data class UpdateShareRequest(
     val attributes: String? = null
 ) {
     companion object {
-        fun createAttributes(capabilities: Capabilities, allowDownloadAndSync: Boolean, type: ShareType): String {
-            if (type != ShareType.INTERNAL && type != ShareType.USER) {
+        fun createAttributes(capabilities: Capabilities, allowDownloadAndSync: Boolean, type: ShareType?): String {
+            if (type == null || (type != ShareType.INTERNAL && type != ShareType.USER)) {
                 return "[]"
             }
 

app/src/main/java/it/niedermann/owncloud/notes/share/repository/ShareRepository.kt

@@ -21,6 +21,8 @@ import it.niedermann.owncloud.notes.persistence.entity.Note
 import it.niedermann.owncloud.notes.persistence.entity.ShareEntity
 import it.niedermann.owncloud.notes.share.model.CreateShareRequest
 import it.niedermann.owncloud.notes.share.model.CreateShareResponse
+import it.niedermann.owncloud.notes.share.model.ShareAttributesV1
+import it.niedermann.owncloud.notes.share.model.ShareAttributesV2
 import it.niedermann.owncloud.notes.share.model.UpdateSharePermissionRequest
 import it.niedermann.owncloud.notes.share.model.UpdateShareRequest
 import it.niedermann.owncloud.notes.share.model.toOCShareList
@@ -129,6 +131,18 @@ class ShareRepository(private val applicationContext: Context, private val accou
         return notesRepository.getShareByPathAndDisplayName(share)
     }
 
+    fun isAllowDownloadAndSync(share: OCShare): Boolean {
+        val entity = getShareByPathAndDisplayName(share)
+        val attributes = entity?.attributes ?: return false
+        val capabilities = notesRepository.capabilities
+        val shouldUseShareAttributesV2 = (capabilities.nextcloudMajorVersion?.toInt() ?: 0) >= 30
+        return if (shouldUseShareAttributesV2) {
+            ShareAttributesV2.getAttributes(attributes).first().value
+        } else {
+            ShareAttributesV1.getAttributes(attributes).first().enabled
+        }
+    }
+
     private fun LinkedTreeMap<*, *>.getList(key: String): ArrayList<*>? = this[key] as? ArrayList<*>
 
     /**