Also use custom http client (added in #5) for downloading files

Author: normanr

Modio/Client.Download.cs

@@ -93,13 +93,10 @@ public async Task Download(File file, FileInfo dest, CancellationToken cancellat
     /// </summary>
     public async Task Download(File file, Stream stream, CancellationToken cancellationToken = default)
     {
-        var client = new HttpClient();
         try
         {
-            using (var input = await client.GetStreamAsync(file.Download?.BinaryUrl))
-            {
-                await input.CopyToAsync(stream, 81920 /* default buffer size */, cancellationToken);
-            }
+            using var input = await httpClient.GetStreamAsync(file.Download?.BinaryUrl);
+            await input.CopyToAsync(stream, 81920 /* default buffer size */, cancellationToken);
         }
         catch (NotFoundException ex)
         {

Modio/Client.cs

@@ -24,7 +24,9 @@ public partial class Client
 
     private static readonly string X_MODIO_PLATFORM_HDR = "X-Modio-Platform";
 
-    private IConnection connection;
+    private readonly HttpClient httpClient;
+
+    private readonly IConnection connection;
 
     /// <summary>
     /// Client for the Authentication API.
@@ -49,7 +51,7 @@ public Client(Options options)
         var apiKey = options.ApiKey;
         var token = options.Token;
         var baseAddress = FixBaseUrl(options.BaseUrl);
-        var httpClient = options.HttpClient ?? new HttpClient();
+        httpClient = options.HttpClient ?? new HttpClient();
 
         if (options.TargetPlatform != null && !httpClient.DefaultRequestHeaders.Contains(X_MODIO_PLATFORM_HDR))
         {
@@ -82,12 +84,13 @@ public Client(Uri baseUrl, Credentials credentials) : this(new Connection(FixBas
     /// Initializes a new instance of <see cref="Client"/> with a custom host, custom <paramref name="credentials"/>, and a custom <paramref name="httpClient"/>.
     /// </summary>
     [Obsolete("Use `Client(Client.Options)` or `Client.GetBuilder(apiKey)` instead")]
-    public Client(Uri baseUrl, Credentials credentials, HttpClient httpClient) : this(new Connection(FixBaseUrl(baseUrl), credentials.ApiKey, credentials.Token, httpClient))
+    public Client(Uri baseUrl, Credentials credentials, HttpClient httpClient) : this(new Connection(FixBaseUrl(baseUrl), credentials.ApiKey, credentials.Token, httpClient), httpClient)
     {
     }
 
-    private Client(IConnection connection)
+    private Client(IConnection connection, HttpClient? httpClient = null)
     {
+        this.httpClient = httpClient ?? new HttpClient();;
         this.connection = connection;
         Auth = new AuthClient(connection);
         Games = new GamesClient(connection);