fix: Fixed matching bug ".gitignore" also matched "foo.gitignore"

Author: nielsbasjes

CHANGELOG.md

@@ -4,7 +4,7 @@ This is intended as an overview of the major changes
 
 NEXT VERSION
 ===
-- ...
+- Fixed matching bug ".gitignore" also matched "foo.gitignore"
 
 v.1.14.0
 ===

codeowners-reader/src/main/java/nl/basjes/codeowners/Rule.java

@@ -33,7 +33,7 @@ public Rule(String fileExpression) {
             .replace("\\ ", " ") // The escaped spaces must become spaces again.
 
             // If a path does not start with a /, the path is treated as if it starts with a globstar. README.md is treated the same way as /**/README.md
-            .replaceAll("^([^/*.])", "/**/$1")
+            .replaceAll("^([^/*])", "/**/$1")
             // "/foo" --> End can be a filename (so we pin to the end) or a directory name (so we expect another / )
             .replaceAll("([^/*])$", "$1(/|\\$)")
 

codeowners-reader/src/test/java/nl/basjes/codeowners/TestCodeOwnersGitlab.java

@@ -471,4 +471,51 @@ void gitlabExclusionMultipleSections() {
         assertOwners(codeOwners, "/config/something.conf", "@ops-team");
     }
 
+    @Test
+    void gitlabExclusionRealUsecase() {
+        CodeOwners codeOwners = new CodeOwners(
+            "[Code Quality][3] @quality\n" +
+            "*\n" +
+            "\n" +
+            "[Change Management Process][1] @changemanagement\n" +
+            "!/docs/\n" +
+            "!*.md\n" +
+            "!*.example\n" +
+            "!.gitignore\n" +
+            "!.prettierignore\n" +
+            "*"
+        );
+
+        codeOwners.setVerbose(true);
+        assertOwners(codeOwners, "README.md",             "@quality"); // Not for *.md
+        assertOwners(codeOwners, "docs/README.md",        "@quality"); // Not for *.md
+        assertOwners(codeOwners, "subdir/README.md",      "@quality"); // Not for *.md
+        assertOwners(codeOwners, "Something.rb",          "@quality", "@changemanagement");
+        assertOwners(codeOwners, "docs/Something.rb",     "@quality"); // Not in /docs/
+        assertOwners(codeOwners, "subdir/Something.rb",   "@quality", "@changemanagement");
+        assertOwners(codeOwners, "Foo.gitignore",         "@quality", "@changemanagement");
+        assertOwners(codeOwners, ".gitignore",            "@quality"); // Not .gitignore
+        assertOwners(codeOwners, "docs/Foo.gitignore",    "@quality"); // Not in /docs/
+        assertOwners(codeOwners, "docs/.gitignore",       "@quality"); // Not in /docs/ AND Not .gitignore
+        assertOwners(codeOwners, "subdir/Foo.gitignore",  "@quality", "@changemanagement");
+        assertOwners(codeOwners, "subdir/.gitignore",     "@quality"); // Not .gitignore
+    }
+
+
+    @Test
+    void gitlabFileMatchingBugReproduction() {
+        // The bug: The second line also matches "foo.gitignore"
+        CodeOwners codeOwners = new CodeOwners(
+            "*.gitignore @one\n" +
+            ".gitignore @two\n"
+        );
+        codeOwners.setVerbose(true);
+        assertOwners(codeOwners, ".gitignore", "@two"); // Last match in a section is used
+        assertOwners(codeOwners, "foo.gitignore", "@one");
+        assertOwners(codeOwners, "/.gitignore", "@two"); // Last match in a section is used
+        assertOwners(codeOwners, "/foo.gitignore", "@one");
+        assertOwners(codeOwners, "/subdir/.gitignore", "@two");
+        assertOwners(codeOwners, "/subdir/foo.gitignore", "@one");
+    }
+
 }