Skip to content

[DX Weirdness] URL Parameter specified twice in Ninetailed class constructor parameters #43

@cwkosman

Description

@cwkosman

Describe the bug
When using the Ninetailed class constructor from the JS SDK, there are two parameters to specify a URL:

  1. a url property in the first object of type ninetailedApiClientInstanceOrOptions
  2. a url property in the second object of type options

Only the second url property is actually used by the constructor.

Expected behavior
A clear and concise description of what you expected to happen.
Have only url parameter. Either:

  1. Remove the url property of the first parameter to keep the code as it functions now, OR
  2. Remove the url property of the second parameter to more closely match the type signature of constructing a NinetailedApiClient

Versions
Please list packages version, browser, node version, etc.
Present on latest 7.x.x package.

Additional context
Add any other context about the problem here.
Code: https://github.com/ninetailed-inc/experience.js/blob/main/packages/sdks/javascript/src/lib/Ninetailed.ts#L102

Metadata

Metadata

Labels

bugSomething isn't workingtriage

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions