Skip to content

Commit b416b96

Browse files
Copilotnomeguy
andcommitted
Fix code review issues: remove MySQL passwords, fix node version syntax, remove quotes from object keys
Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
1 parent b20a059 commit b416b96

File tree

2 files changed

+5
-7
lines changed

2 files changed

+5
-7
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,11 @@ jobs:
3030
uses: mirromutth/mysql-action@v1.1
3131
with:
3232
mysql database: casbin
33-
mysql root password: password
3433

3534
- name: Set up Node.js
3635
uses: actions/setup-node@v2.1.5
3736
with:
38-
node-version: ^20
37+
node-version: 20
3938

4039
- name: Install Dependency
4140
run: yarn install
@@ -54,15 +53,14 @@ jobs:
5453
runs-on: ubuntu-latest
5554
strategy:
5655
matrix:
57-
node: [^18, ^20]
56+
node: ['18', '20']
5857
steps:
5958
- uses: actions/checkout@v2
6059

6160
- name: Setup MySQL
6261
uses: mirromutth/mysql-action@v1.1
6362
with:
6463
mysql database: casbin
65-
mysql root password: password
6664

6765
- name: Set up Node.js
6866
uses: actions/setup-node@v3
@@ -84,7 +82,7 @@ jobs:
8482
- name: Set up Node.js
8583
uses: actions/setup-node@v3
8684
with:
87-
node-version: ^20
85+
node-version: 20
8886

8987
- name: Run semantic-release
9088
if: github.repository == 'node-casbin/sequelize-adapter' && github.event_name == 'push'

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ async function myFunction() {
8383

8484
// Load the filtered policy from DB.
8585
await e.loadFilteredPolicy({
86-
'ptype': 'p',
87-
'v0': 'alice'
86+
ptype: 'p',
87+
v0: 'alice'
8888
});
8989

9090
// Check the permission.

0 commit comments

Comments
 (0)