* Refactored CFGGenerator to use Mox

** This is a compromise to slowly transition:

** The issue is that ExpressionProcessors now uses dependency injection via Application.get_env/3,
** but the main CFGGenerator and other parts of the system still directly call the concrete modules.
** This creates a mismatch.

In this change we: Set the default Application environment values and fix the dependency injection pattern.

For future refactoring that is done wholistically: Refactor the entire CFG generation pipeline to use dependency injection consistently.

Author: NSHkr

config/test.exs

@@ -46,7 +46,19 @@ config :elixir_scope,
   interface: [
     iex_helpers: false,             # Disable IEx helpers in tests
     query_timeout: 1000             # Quick timeout for tests
-  ]
+  ],
+
+  state_manager: ElixirScope.ASTRepository.Enhanced.CFGGenerator.StateManager,
+  ast_utilities: ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTUtilities,  
+  ast_processor: ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTProcessor
+
+
+
+
+
+
+
+
 
 config :elixir_scope, :pattern_matcher,
   # Faster execution for tests

lib/elixir_scope/application.ex

@@ -15,6 +15,8 @@ defmodule ElixirScope.Application do
   def start(_type, _args) do
     Logger.info("Starting ElixirScope application...")
 
+    ensure_default_cfg_dependencies()
+
     children = [
       # Core configuration and utilities (no dependencies)
       {ElixirScope.Config, []},
@@ -42,9 +44,26 @@ defmodule ElixirScope.Application do
     end
   end
 
+  defp ensure_default_cfg_dependencies do
+    unless Application.get_env(:elixir_scope, :state_manager) do
+      Application.put_env(:elixir_scope, :state_manager,
+        ElixirScope.ASTRepository.Enhanced.CFGGenerator.StateManager)
+    end
+
+    unless Application.get_env(:elixir_scope, :ast_utilities) do
+      Application.put_env(:elixir_scope, :ast_utilities,
+        ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTUtilities)
+    end
+
+    unless Application.get_env(:elixir_scope, :ast_processor) do
+      Application.put_env(:elixir_scope, :ast_processor,
+        ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTProcessor)
+    end
+  end
+
   @impl true
   def stop(_state) do
     Logger.info("Stopping ElixirScope application...")
     :ok
   end
-end 
+end 

lib/elixir_scope/ast_repository/enhanced/cfg_generator/ast_processor.ex

@@ -3,6 +3,8 @@ defmodule ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTProcessor do
   Main AST processing functions for the CFG generator.
   """
 
+  @behaviour ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTProcessorBehaviour
+
   alias ElixirScope.ASTRepository.Enhanced.{CFGNode, CFGEdge, ScopeInfo}
   alias ElixirScope.ASTRepository.Enhanced.CFGGenerator.{
     StateManager, ASTUtilities, ControlFlowProcessors, ExpressionProcessors
@@ -11,10 +13,12 @@ defmodule ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTProcessor do
   @doc """
   Processes a function body AST and returns CFG components.
   """
+  @impl ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTProcessorBehaviour
   def process_function_body({:def, meta, [head, [do: body]]}, state) do
     process_function_body({:defp, meta, [head, [do: body]]}, state)
   end
 
+  @impl ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTProcessorBehaviour
   def process_function_body({:defp, meta, [head, [do: body]]}, state) do
     line = ASTUtilities.get_line_number(meta)
 
@@ -117,6 +121,7 @@ defmodule ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTProcessor do
   @doc """
   Main AST node processing dispatcher.
   """
+  @impl ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTProcessorBehaviour
   def process_ast_node(ast, state) do
     case ast do
       # Block of statements - put this FIRST to ensure it matches before function call pattern

lib/elixir_scope/ast_repository/enhanced/cfg_generator/ast_processor_behavior.ex

@@ -0,0 +1,24 @@
+defmodule ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTProcessorBehaviour do
+  @moduledoc """
+  Behaviour for main AST processing functions for the CFG generator.
+  """
+
+  alias ElixirScope.ASTRepository.Enhanced.{CFGNode, CFGEdge, ScopeInfo}
+  alias ElixirScope.ASTRepository.Enhanced.CFGGenerator.State
+
+  @type nodes_map :: %{String.t() => CFGNode.t()}
+  @type edges_list :: [CFGEdge.t()]
+  @type exits_list :: [String.t()]
+  @type scopes_map :: %{String.t() => ScopeInfo.t()}
+  @type process_result :: {nodes_map(), edges_list(), exits_list(), scopes_map(), State.t()} | {:error, any()}
+
+  @doc """
+  Processes a function body AST and returns CFG components.
+  """
+  @callback process_function_body(function_ast :: term(), state :: State.t()) :: process_result()
+
+  @doc """
+  Main AST node processing dispatcher.
+  """
+  @callback process_ast_node(ast :: term(), state :: State.t()) :: process_result()
+end

lib/elixir_scope/ast_repository/enhanced/cfg_generator/ast_utilities.ex

@@ -3,23 +3,28 @@ defmodule ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTUtilities do
   Utility functions for working with AST nodes.
   """
 
+  @behaviour ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTUtilitiesBehaviour
+
   @doc """
   Extracts AST node ID from metadata.
   """
+  @impl ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTUtilitiesBehaviour
   def get_ast_node_id(meta) do
     Keyword.get(meta, :ast_node_id)
   end
 
   @doc """
   Extracts line number from metadata.
   """
+  @impl ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTUtilitiesBehaviour
   def get_line_number(meta) do
     Keyword.get(meta, :line, 1)
   end
 
   @doc """
   Extracts function parameters from function head.
   """
+  @impl ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTUtilitiesBehaviour
   def extract_function_parameters({_name, _meta, args}) when is_list(args) do
     Enum.map(args, fn
       {var, _meta, nil} when is_atom(var) -> Atom.to_string(var)
@@ -32,6 +37,7 @@ defmodule ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTUtilities do
   @doc """
   Extracts variable names from a pattern.
   """
+  @impl ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTUtilitiesBehaviour
   def extract_pattern_variables(pattern) do
     case pattern do
       {var, _meta, nil} when is_atom(var) -> [Atom.to_string(var)]
@@ -44,6 +50,7 @@ defmodule ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTUtilities do
   @doc """
   Calculates pattern matching probability (simplified).
   """
+  @impl ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTUtilitiesBehaviour
   def calculate_pattern_probability(_pattern) do
     # Simplified probability - could be more sophisticated
     0.5
@@ -52,6 +59,7 @@ defmodule ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTUtilities do
   @doc """
   Determines the type of a literal value.
   """
+  @impl ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTUtilitiesBehaviour
   def get_literal_type(literal) do
     cond do
       is_atom(literal) -> :atom
@@ -65,6 +73,7 @@ defmodule ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTUtilities do
   @doc """
   Analyzes comprehension clauses to separate generators and filters.
   """
+  @impl ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTUtilitiesBehaviour
   def analyze_comprehension_clauses(clauses) do
     Enum.reduce(clauses, {[], []}, fn clause, {generators, filters} ->
       case clause do

lib/elixir_scope/ast_repository/enhanced/cfg_generator/ast_utilities_behavior.ex

@@ -0,0 +1,47 @@
+defmodule ElixirScope.ASTRepository.Enhanced.CFGGenerator.ASTUtilitiesBehaviour do
+  @moduledoc """
+  Behaviour for utility functions for working with AST nodes.
+  """
+
+  @type meta :: keyword()
+  @type literal :: atom() | number() | binary() | list()
+  @type pattern :: term()
+  @type function_head :: {atom(), meta(), list() | nil}
+  @type comprehension_clauses :: list(term())
+
+  @doc """
+  Extracts AST node ID from metadata.
+  """
+  @callback get_ast_node_id(meta :: meta()) :: String.t() | nil
+
+  @doc """
+  Extracts line number from metadata.
+  """
+  @callback get_line_number(meta :: meta()) :: non_neg_integer()
+
+  @doc """
+  Extracts function parameters from function head.
+  """
+  @callback extract_function_parameters(head :: function_head()) :: [String.t()]
+
+  @doc """
+  Extracts variable names from a pattern.
+  """
+  @callback extract_pattern_variables(pattern :: pattern()) :: [String.t()]
+
+  @doc """
+  Calculates pattern matching probability (simplified).
+  """
+  @callback calculate_pattern_probability(pattern :: pattern()) :: float()
+
+  @doc """
+  Determines the type of a literal value.
+  """
+  @callback get_literal_type(literal :: literal()) :: atom()
+
+  @doc """
+  Analyzes comprehension clauses to separate generators and filters.
+  """
+  @callback analyze_comprehension_clauses(clauses :: comprehension_clauses()) ::
+    {generators :: list(term()), filters :: list(term())}
+end