Review self-custodian solution #2761
Description
We need to support the team working on the self-custodian solution by code reviewing the work.
Repo is here: https://github.com/o1-labs-XT/multisig-zkapp
There are 4 areas of interest, to make sure:
- Multi-signature approval logic is implemented correctly including the membership checks, nonce replay protection etc.
- Permission configurations are fitting with the technical requirements without any potential security issues
- Token delegation is secure including message construction etc.
- Any missing edge cases to add in the unit or integration tests?
Docs on the tech requirements for the full treasury
https://www.notion.so/o1labs/Treasury-2ede79b1f91080a19e81c599108f0e62
Relevant docs for the zkapp
https://www.notion.so/o1labs/Requirements-Self-custody-treasury-2ede79b1f910808698dcc818a836ddf2
https://www.notion.so/o1labs/ZkApp-Architecture-2ede79b1f9108077acecc9c9784a6594