fix: Always mount ConfigMap and add --config flag

When alphaConfig.enabled=true and forceLegacyConfig=false, the
deployment was not mounting the ConfigMap or adding the --config flag
because the condition checked for existingConfig OR configFile.

Since configFile defaults to empty string, the condition was false
and oauth2-proxy failed with 'missing setting for email validation'.

Fixed by removing the conditions entirely:
- ConfigMap volume is always created (using existingConfig if specified)
- ConfigMap is always mounted
- --config flag is always added

This ensures email_domains is always provided to oauth2-proxy,
whether using the generated ConfigMap or an existingConfig.

This is NOT a breaking change - it fixes a bug where the app didn't
work with default values when using alphaConfig.

Signed-off-by: pierluigilenoci <pierluigi.lenoci@gmail.com>
Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>

Author: pierluigilenoci

helm/oauth2-proxy/templates/deployment.yaml

@@ -145,9 +145,7 @@ spec:
             {{- toYaml . | nindent 10 }}
           {{- end }}
         {{- end }}
-        {{- if or .Values.config.existingConfig .Values.config.configFile }}
           - --config=/etc/oauth2_proxy/oauth2_proxy.cfg
-        {{- end }}
         {{- if .Values.authenticatedEmailsFile.enabled }}
         {{- if .Values.authenticatedEmailsFile.template }}
           - --authenticated-emails-file=/etc/oauth2-proxy/{{ .Values.authenticatedEmailsFile.template }}
@@ -298,11 +296,9 @@ spec:
           readOnly: true
 {{- end }}
 {{- end }}
-{{- if or .Values.config.existingConfig .Values.config.configFile }}
         - mountPath: /etc/oauth2_proxy/oauth2_proxy.cfg
           name: configmain
           subPath: oauth2_proxy.cfg
-{{- end }}
 {{- if .Values.alphaConfig.enabled }}
         - mountPath: /etc/oauth2_proxy/oauth2_proxy.yml
           name: configalpha
@@ -366,12 +362,10 @@ spec:
           name: {{ template "oauth2-proxy.fullname" . }}-wait-for-redis
           defaultMode: 0775
 {{- end }}
-{{- if or .Values.config.existingConfig .Values.config.configFile }}
       - configMap:
           defaultMode: 420
           name: {{ if .Values.config.existingConfig }}{{ .Values.config.existingConfig }}{{ else }}{{ template "oauth2-proxy.fullname" . }}{{ end }}
         name: configmain
-{{- end }}
 {{- if .Values.alphaConfig.enabled }}
 {{- if .Values.alphaConfig.existingConfig }}
       - configMap: