Skip to content

Fix CI failures: ESLint ban-ts-comment and async test timing #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 5 commits into from
Feb 4, 2026
Merged

Fix CI failures: ESLint ban-ts-comment and async test timing #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f0c3acf
Initial plan
Copilot Feb 4, 2026
6d47722
Fix lint errors and test failures
Copilot Feb 4, 2026
796b858
Fix remaining @ts-ignore lint errors in plugin-calendar and components
Copilot Feb 4, 2026
067c175
Remove incorrect @ts-expect-error directive from ObjectKanban.tsx
Copilot Feb 4, 2026
1088690
Merge branch 'main' into copilot/fix-all-build-and-test
hotlong Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/components/src/renderers/complex/data-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,18 +491,18 @@ const DataTableRenderer = ({ schema }: { schema: DataTableSchema }) => {
key={rowId}
data-state={isSelected ? 'selected' : undefined}
className={cn(
// @ts-ignore
// @ts-expect-error - onRowClick might not be in schema type definition
schema.onRowClick && "cursor-pointer"
)}
onClick={(e) => {
// @ts-ignore
// @ts-expect-error - onRowClick might not be in schema type definition
if (schema.onRowClick && !e.defaultPrevented) {
// Simple heuristic to avoid triggering on interactive elements if they didn't stop propagation
const target = e.target as HTMLElement;
if (target.closest('button') || target.closest('[role="checkbox"]') || target.closest('a')) {
return;
}
// @ts-ignore
// @ts-expect-error - onRowClick might not be in schema type definition
schema.onRowClick(row);
}
}}
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-kanban/src/ObjectKanban.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export const ObjectKanban: React.FC<ObjectKanbanProps> = ({
if (!Array.isArray(rawData)) return [];

// Support cardTitle property from schema (passed by ObjectView)
// @ts-ignore - cardTitle might not be in KanbanSchema type definition yet
// Fallback to legacy titleField for backwards compatibility
let titleField = schema.cardTitle || (schema as any).titleField;
Comment on lines 103 to 105
Copy link

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KanbanSchema already defines cardTitle (see packages/plugin-kanban/src/types.ts), so this @ts-expect-error will cause a TS compile error (“Unused '@ts-expect-error' directive”) because the next line no longer produces a type error. Remove the directive (and update the comment to reflect that this is a legacy fallback to (schema as any).titleField).

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 067c175. Removed the @ts-expect-error directive and updated the comment to clarify this is a backwards compatibility fallback to titleField.


// Fallback: Try to infer from object definition
Expand Down
1 change: 0 additions & 1 deletion packages/plugin-kanban/vitest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
/// <reference types="vitest" />
import { defineConfig } from 'vite';
import react from '@vitejs/plugin-react';
import path from 'path';

export default defineConfig({
plugins: [react()],
Expand Down
4 changes: 3 additions & 1 deletion packages/plugin-timeline/src/ObjectTimeline.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ describe('ObjectTimeline', () => {
expect(mockDataSource.find).toHaveBeenCalled();
});

expect(screen.getByText('Event 1')).toBeDefined();
await waitFor(() => {
expect(screen.getByText('Event 1')).toBeDefined();
});
});
});
Loading