[exporter/prometheusremotewrite] Fix WAL wake-up race#46234
Open
ShaanveerS wants to merge 1 commit intoopen-telemetry:mainfrom
Open
[exporter/prometheusremotewrite] Fix WAL wake-up race#46234ShaanveerS wants to merge 1 commit intoopen-telemetry:mainfrom
ShaanveerS wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Use a buffered notify channel and signal only after successful WAL writes to avoid lost wake-ups. Add a regression test for queued notifications when no reader is currently waiting. Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
ShaanveerS
requested review from
a team,
ArthurSens and
dashpole
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates WAL reader/writer signaling to avoid missed wake-ups.
Link to tracking issue
Fixes #45288
Testing
stress -p 32 -count 200 on
TestExportWithWALEnabled