Draft: Unique DB Instance Identifier SQLServer receiver#46238
Draft
akshays-19 wants to merge 2 commits intoopen-telemetry:mainfrom
Draft
Draft: Unique DB Instance Identifier SQLServer receiver#46238akshays-19 wants to merge 2 commits intoopen-telemetry:mainfrom
akshays-19 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
github-actions
bot
added
receiver/sqlserver
Run Windows
XSAM
reviewed
Feb 20, 2026
|
|
||
| // applyResourceOverrides applies user-defined resource attribute overrides to the ResourceBuilder | ||
| func (s *sqlServerScraperHelper) applyResourceOverrides(rb *metadata.ResourceBuilder) { | ||
| for key, value := range s.config.ResourceAttributesOverride { |
Member
There was a problem hiding this comment.
Could we make it as a general feature, and don't limit the key list?
Maybe change this part to make sure this override won't be overrided by other logic?
s.mb.EmitForResource(metadata.WithResource(rb.Emit()))
XSAM
reviewed
Feb 20, 2026
Member
XSAM
left a comment
XSAM
left a comment
There was a problem hiding this comment.
Could you add tests for metrics and logs to verify the override logic?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enhancement adds a
resource_attributes_overrideconfiguration option that allows users to overrideany resource attribute. Particularly for settingservice.instance.id,service.name, andservice.namespaceto uniquely identify database instances across environmentsFixes #46176