Skip to content

Bytes: Fix length from fromBytes on JS #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Geokureli wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Bytes: Fix length from fromBytes on JS #2025

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a27161
Bytes: fix length on JS
Geokureli Jan 25, 2026
b4fe804
add url to comment
Geokureli Jan 25, 2026
26095f0
Set internal length manually
Geokureli Jan 26, 2026
b28a2f1
Move comment line
Geokureli Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/lime/utils/Bytes.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ abstract Bytes(HaxeBytes) from HaxeBytes to HaxeBytes
{
#if js
this = new HaxeBytes(bytesData);
// bytesData may have extra bytes. See https://github.com/HaxeFoundation/haxe/issues/8974
this.length = length;
#elseif hl
this = new HaxeBytes(bytesData, length);
#else
Expand Down