Skip to content

Commit d913017

Browse files
[knx] Prevent reconfigutation of IP routers (#19850)
Follow-up to #19839. Discover separate Things for KNX IP routers and avoid setting IP address and port for routers. Routers use a defined multicast address. Make sure that Thing for router is separate, event if the same device exports a tunneling device. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
1 parent 0719fbf commit d913017

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/discovery/KNXnetDiscoveryService.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,10 @@ private synchronized void startDiscovery() {
119119
}
120120
if (services.containsKey(ServiceFamiliesDIB.ServiceFamily.Routing)) {
121121
// .withProperty("type", "ROUTER") was omitted to avoid reconfiguration
122-
thingDiscovered(DiscoveryResultBuilder.create(new ThingUID(THING_TYPE_IP_BRIDGE, serial))
122+
thingDiscovered(DiscoveryResultBuilder.create(new ThingUID(THING_TYPE_IP_BRIDGE, serial + "-r"))
123123
.withLabel(response.getDevice().getName() + " (router mode)")
124-
.withProperty("serialNumber", serial + "-r").withProperty("ipAddress", "224.0.23.12")
125-
.withProperty("port", "" + response.getControlEndpoint().endpoint().getPort())
126-
.withRepresentationProperty("serialNumber").build());
124+
.withProperty("serialNumber", serial + "-r").withRepresentationProperty("serialNumber")
125+
.build());
127126
}
128127
} else {
129128
logger.trace("Ignoring device {}", response);

0 commit comments

Comments
 (0)