[ism8] Binding ism8 doesn't support UoM, values don't update

[schmidmuc]

Expected Behavior

It should be possible to link ism8 channels to items with UoM, such as Number:Temperature for all temperature values, etc.

Current Behavior

When linking an ism8 temperature channel to a Number:Temperature item values are not updated.

Possible Solution

Integrate UoM support to binding.

[Hilbrand]

This is not a bug. But by design. I suspect this binding was created before UoM types was introduced.

[schmidmuc]

The binding was introduced as a new binding with release 2.5.9 - UoM were introduced a long time before.
Anyhow it doesn't matter if bug or enhancement - especially for OH3 a missing UoM support is getting more and more a problem.

[lsiepel]

@schmidmuc looking at the binding, it internally allready has units specified in many cases. So i don't think it will be hard to implement it. The problem is that i don't have a ism8 device and that makes testing and polishing tedious.

@holgerfriedrich did a PR last week to this binding, don't know if he is planning to do more changes?

Anyway, i'm fine spending some time on it, but i do need others to test and verify.

[holgerfriedrich]

@lsiepel I do not plan to spend more time here, still busy with knx binding. I just went through the bindings I have used before and did some quick fixes. My ism8 is now connected to a BAOS device and no loger available for testing.

[lsiepel]

Thanks for the quick response, maybe @schmidmuc is available for testing, otherwise i pass on this.

[schmidmuc]

Thanks for the quick response, maybe @schmidmuc is available for testing, otherwise i pass on this.

Thanks, that you would spend efforts to work on this topic. I have the ISM8 still in use, so I could support with testing when getting the jar file including the changes.

[lsiepel]

Made a first attempt. 3.4.1 Jar is available here: https://1drv.ms/u/s!AnMcxmvEeupwjp4L347Q22cnMI1QQg?e=ROo8Y1
Sources (4.0.0) here: https://github.com/lsiepel/openhab-addons/tree/ism8-uom-400

Used UoM types.

QuantityType<Temperature>((Double) value, SIUnits.CELSIUS);
QuantityType<Temperature>((Double) value, Units.KELVIN);
QuantityType<VolumetricFlowRate>((Double) value, Units.CUBICMETRE_PER_HOUR);
QuantityType<Pressure>((Double) value, Units.BAR);
QuantityType<Dimensionless>((Double) value, Units.PERCENT);
QuantityType<Dimensionless>((Double) value, Units.ONE);
OnOffType.from((boolean) value);

If you test, please enable debug loging if you have any issues. I mainly focused on data flowing from the device to openHAB.
When all that works fine, i hope you can also test sending commands from openHAB to the device and specific when you have units setup in a different locale (Fahrenheit vs Celsius etc.)

Edit: The channel types have changes, so you need to setup the channels again. I added a table to the readme.md half -way: https://github.com/lsiepel/openhab-addons/blob/ism8-uom-400/bundles/org.openhab.binding.ism8/README.md

[schmidmuc]

Did some first tests with 3.4.1 version:

Getting values from read-only ISM values to OpenHab items seems to work.

But I'm wondering if in things configuration menu with channel ribbon opened (shown in following screenshot) channel type shouldn't be "Number:Temperature" instead of "Number"?

Setting a writeable value didn't work in a first try, but not sure if this worked with former version, as I do not use this regularly:

[lsiepel]

Yes that should have been Number:Temperature. Did you re-create this channel? (delete and add it)
Can you share more of the configured Thing/ChannelItem. Do you have any profiles/transformations in place?

Writing the value failed because the unit was also send to the channel. It should only send the number. Do you use some formatting on the item? I'll also look on the code side if there is anything i have missed or can be improved.

Thanks for first results!