From f50c95c9b3f587281aecde00775813b9fa001eee Mon Sep 17 00:00:00 2001 From: Jeremy Setton Date: Sun, 5 Jan 2025 03:31:20 -0500 Subject: [PATCH] [insteon] Fix legacy all link broadcast message not processed Signed-off-by: Jeremy Setton --- .../binding/insteon/internal/InsteonLegacyBinding.java | 2 +- .../openhab/binding/insteon/internal/device/LegacyDevice.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/bundles/org.openhab.binding.insteon/src/main/java/org/openhab/binding/insteon/internal/InsteonLegacyBinding.java b/bundles/org.openhab.binding.insteon/src/main/java/org/openhab/binding/insteon/internal/InsteonLegacyBinding.java index 1b5a2453ee380..c2f551e063ca3 100644 --- a/bundles/org.openhab.binding.insteon/src/main/java/org/openhab/binding/insteon/internal/InsteonLegacyBinding.java +++ b/bundles/org.openhab.binding.insteon/src/main/java/org/openhab/binding/insteon/internal/InsteonLegacyBinding.java @@ -514,7 +514,7 @@ public void disconnected() { private void handleInsteonMessage(Msg msg) throws FieldException { InsteonAddress toAddr = msg.getInsteonAddress("toAddress"); - if (!msg.isBroadcast() && !driver.isMsgForUs(toAddr)) { + if (!msg.isBroadcast() && !msg.isAllLinkBroadcast() && !driver.isMsgForUs(toAddr)) { // not for one of our modems, do not process return; } diff --git a/bundles/org.openhab.binding.insteon/src/main/java/org/openhab/binding/insteon/internal/device/LegacyDevice.java b/bundles/org.openhab.binding.insteon/src/main/java/org/openhab/binding/insteon/internal/device/LegacyDevice.java index 08caef8f15e18..5c660b165ca9b 100644 --- a/bundles/org.openhab.binding.insteon/src/main/java/org/openhab/binding/insteon/internal/device/LegacyDevice.java +++ b/bundles/org.openhab.binding.insteon/src/main/java/org/openhab/binding/insteon/internal/device/LegacyDevice.java @@ -334,7 +334,7 @@ public long processRequestQueue(long timeNow) { if (qe == null) { return 0L; } - if (!qe.getMsg().isBroadcast()) { + if (!qe.getMsg().isAllLinkBroadcast()) { logger.debug("qe taken off direct: {} {}", qe.getFeature(), qe.getMsg()); lastQueryTime = timeNow; // mark feature as pending @@ -382,7 +382,7 @@ public void enqueueDelayedMessage(Msg msg, LegacyDeviceFeature feature, long del synchronized (mrequestQueue) { mrequestQueue.add(new QEntry(feature, msg, now + delay)); } - if (!msg.isBroadcast()) { + if (!msg.isAllLinkBroadcast()) { msg.setQuietTime(QUIET_TIME_DIRECT_MESSAGE); } logger.trace("enqueing direct message with delay {}", delay);