From 0f085650995d9c490dc9904ebae4ba359b4dd152 Mon Sep 17 00:00:00 2001
From: Andrew Fiddian-Green <software@whitebear.ch>
Date: Mon, 14 Apr 2025 11:16:50 +0100
Subject: [PATCH 1/3] Add semantic tags

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
---
 .../src/main/resources/OH-INF/thing/thing-types.xml | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/bundles/org.openhab.binding.harmonyhub/src/main/resources/OH-INF/thing/thing-types.xml b/bundles/org.openhab.binding.harmonyhub/src/main/resources/OH-INF/thing/thing-types.xml
index 04738360aee0e..dde8e2218e6fb 100644
--- a/bundles/org.openhab.binding.harmonyhub/src/main/resources/OH-INF/thing/thing-types.xml
+++ b/bundles/org.openhab.binding.harmonyhub/src/main/resources/OH-INF/thing/thing-types.xml
@@ -7,6 +7,7 @@
 	<bridge-type id="hub">
 		<label>Harmony Hub</label>
 		<description>A Logitech Harmony Hub</description>
+		<semantic-equipment-tag>NetworkAppliance</semantic-equipment-tag>
 		<channels>
 			<channel id="currentActivity" typeId="currentActivity"/>
 			<channel id="activityStarting" typeId="eventTrigger">
@@ -48,6 +49,7 @@
 		</supported-bridge-type-refs>
 		<label>Harmony Device</label>
 		<description>Logitech Harmony Hub Device</description>
+		<semantic-equipment-tag>AudioVisual</semantic-equipment-tag>
 		<channels>
 			<channel id="buttonPress" typeId="buttonPress"/>
 		</channels>
@@ -67,6 +69,10 @@
 		<item-type>String</item-type>
 		<label>Current Activity</label>
 		<description>The label/name of the current activity of a Harmony Hub</description>
+		<tags>
+			<tag>Status</tag>
+			<tag>Mode</tag>
+		</tags>
 	</channel-type>
 
 	<channel-type id="eventTrigger">
@@ -79,6 +85,9 @@
 		<item-type>String</item-type>
 		<label>Button Press</label>
 		<description>The label/name of the button to press on a Harmony Hub device (write only)</description>
+		<tags>
+			<tag>Control</tag>
+		</tags>
 	</channel-type>
 
 	<channel-type id="player">
@@ -86,6 +95,10 @@
 		<label>Player Control</label>
 		<description>Send player commands (Rewind,FastForward,Play,Pause,SkipForward,SkipBackwards) to the device associated
 			with the current running activity.</description>
+		<tags>
+			<tag>Control</tag>
+			<tag>MediaControl</tag>
+		</tags>
 	</channel-type>
 
 </thing:thing-descriptions>

From 5a42cfa1bc139626017dcce824ff539fac8f3637 Mon Sep 17 00:00:00 2001
From: Andrew Fiddian-Green <software@whitebear.ch>
Date: Mon, 12 May 2025 17:05:35 +0100
Subject: [PATCH 2/3] adopt reviewer hints

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
---
 .../src/main/resources/OH-INF/thing/thing-types.xml          | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/bundles/org.openhab.binding.harmonyhub/src/main/resources/OH-INF/thing/thing-types.xml b/bundles/org.openhab.binding.harmonyhub/src/main/resources/OH-INF/thing/thing-types.xml
index dde8e2218e6fb..290f9400e1248 100644
--- a/bundles/org.openhab.binding.harmonyhub/src/main/resources/OH-INF/thing/thing-types.xml
+++ b/bundles/org.openhab.binding.harmonyhub/src/main/resources/OH-INF/thing/thing-types.xml
@@ -49,7 +49,7 @@
 		</supported-bridge-type-refs>
 		<label>Harmony Device</label>
 		<description>Logitech Harmony Hub Device</description>
-		<semantic-equipment-tag>AudioVisual</semantic-equipment-tag>
+
 		<channels>
 			<channel id="buttonPress" typeId="buttonPress"/>
 		</channels>
@@ -85,9 +85,6 @@
 		<item-type>String</item-type>
 		<label>Button Press</label>
 		<description>The label/name of the button to press on a Harmony Hub device (write only)</description>
-		<tags>
-			<tag>Control</tag>
-		</tags>
 	</channel-type>
 
 	<channel-type id="player">

From 61f2e6fdcc5223090c363f3a23903af96d860abb Mon Sep 17 00:00:00 2001
From: Jacob Laursen <jacob-github@vindvejr.dk>
Date: Mon, 12 May 2025 22:45:05 +0200
Subject: [PATCH 3/3] Remove linefeed

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
---
 .../src/main/resources/OH-INF/thing/thing-types.xml              | 1 -
 1 file changed, 1 deletion(-)

diff --git a/bundles/org.openhab.binding.harmonyhub/src/main/resources/OH-INF/thing/thing-types.xml b/bundles/org.openhab.binding.harmonyhub/src/main/resources/OH-INF/thing/thing-types.xml
index 290f9400e1248..21632a44265d6 100644
--- a/bundles/org.openhab.binding.harmonyhub/src/main/resources/OH-INF/thing/thing-types.xml
+++ b/bundles/org.openhab.binding.harmonyhub/src/main/resources/OH-INF/thing/thing-types.xml
@@ -49,7 +49,6 @@
 		</supported-bridge-type-refs>
 		<label>Harmony Device</label>
 		<description>Logitech Harmony Hub Device</description>
-
 		<channels>
 			<channel id="buttonPress" typeId="buttonPress"/>
 		</channels>