From cd6bc07cdc4578c9d3d82b64cd84341be9c359bc Mon Sep 17 00:00:00 2001
From: Leo Siepel <leosiepel@gmail.com>
Date: Fri, 31 Oct 2025 16:06:44 +0100
Subject: [PATCH 1/2] Fix channel metadata

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
---
 .../resources/OH-INF/i18n/souliss.properties  |  4 +-
 .../resources/OH-INF/thing/thing-types.xml    | 21 +++++++---
 .../resources/OH-INF/update/instructions.xml  | 38 +++++++++++++++++++
 3 files changed, 56 insertions(+), 7 deletions(-)
 create mode 100644 bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/update/instructions.xml

diff --git a/bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/i18n/souliss.properties b/bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/i18n/souliss.properties
index 3c252bec89ae8..6b2d82c54763e 100644
--- a/bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/i18n/souliss.properties
+++ b/bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/i18n/souliss.properties
@@ -260,8 +260,8 @@ channel-type.souliss.autoMode.label = On/Off Auto Mode
 channel-type.souliss.autoMode.description = Switch on/off
 channel-type.souliss.button.label = Button
 channel-type.souliss.button.description = Button to trigger something
-channel-type.souliss.buttonReadOnly.label = Button
-channel-type.souliss.buttonReadOnly.description = Button to trigger something
+channel-type.souliss.buttonReadOnly.label = Status
+channel-type.souliss.buttonReadOnly.description = Read-only status indicator
 channel-type.souliss.dimmerBrightness.label = Dimmer Brightness
 channel-type.souliss.dimmerBrightness.description = The brightness can be set in 16 steps for RGBW/White leds and in 64 steps for RGBWW leds
 channel-type.souliss.fan-channel.label = Fan
diff --git a/bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/thing/thing-types.xml b/bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/thing/thing-types.xml
index d2e865cc0a312..2745014527b7d 100644
--- a/bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/thing/thing-types.xml
+++ b/bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/thing/thing-types.xml
@@ -495,6 +495,9 @@
 			<channel id="lastStatusStored" typeId="lastStatusStored"/>
 			<channel id="healthy" typeId="healthy"/>
 		</channels>
+		<properties>
+			<property name="thingTypeVersion">1</property>
+		</properties>
 		<config-description>
 			<parameter name="node" type="integer" min="0" max="256">
 				<label>Node</label>
@@ -527,8 +530,10 @@
 			</channel>
 			<channel id="lastStatusStored" typeId="lastStatusStored"/>
 			<channel id="healthy" typeId="healthy"/>
-
 		</channels>
+		<properties>
+			<property name="thingTypeVersion">1</property>
+		</properties>
 		<config-description>
 			<parameter name="node" type="integer" min="0" max="256">
 				<label>Node</label>
@@ -568,6 +573,9 @@
 			<channel id="lastStatusStored" typeId="lastStatusStored"/>
 			<channel id="healthy" typeId="healthy"/>
 		</channels>
+		<properties>
+			<property name="thingTypeVersion">1</property>
+		</properties>
 		<config-description>
 			<parameter name="node" type="integer" min="0" max="256">
 				<label>Node</label>
@@ -773,10 +781,13 @@
 		<label>T58</label>
 		<description>Pressure measure (0, 1500) hPa</description>
 		<channels>
-			<channel id="value" typeId="power"/>
+			<channel id="value" typeId="pressure"/>
 			<channel id="lastStatusStored" typeId="lastStatusStored"/>
 			<channel id="healthy" typeId="healthy"/>
 		</channels>
+		<properties>
+			<property name="thingTypeVersion">1</property>
+		</properties>
 		<config-description>
 			<parameter name="node" type="integer" min="0" max="256">
 				<label>Node</label>
@@ -1058,12 +1069,12 @@
 
 	<channel-type id="buttonReadOnly">
 		<item-type>Switch</item-type>
-		<label>Button</label>
-		<description>Button to trigger something</description>
+		<label>Status</label>
+		<description>Read-only status indicator</description>
 		<category>Switch</category>
+		<state readOnly="true"/>
 	</channel-type>
 
-
 	<channel-type id="pulse">
 		<item-type>Switch</item-type>
 		<label>Pulse</label>
diff --git a/bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/update/instructions.xml b/bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/update/instructions.xml
new file mode 100644
index 0000000000000..cc6ef38bf2969
--- /dev/null
+++ b/bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/update/instructions.xml
@@ -0,0 +1,38 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
+<update:update-descriptions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+	xmlns:update="https://openhab.org/schemas/update-description/v1.0.0"
+	xsi:schemaLocation="https://openhab.org/schemas/update-description/v1.0.0 https://openhab.org/schemas/update-description-1.0.0.xsd">
+
+	<thing-type uid="souliss:t31">
+		<instruction-set targetVersion="1">
+			<update-channel id="fire">
+				<type>souliss:buttonReadOnly</type>
+			</update-channel>
+		</instruction-set>
+	</thing-type>
+
+	<thing-type uid="souliss:t41">
+		<instruction-set targetVersion="1">
+			<update-channel id="statusAlarm">
+				<type>souliss:buttonReadOnly</type>
+			</update-channel>
+		</instruction-set>
+	</thing-type>
+
+	<thing-type uid="souliss:t42">
+		<instruction-set targetVersion="1">
+			<update-channel id="statusAlarm">
+				<type>souliss:buttonReadOnly</type>
+			</update-channel>
+		</instruction-set>
+	</thing-type>
+
+	<thing-type uid="souliss:t58">
+		<instruction-set targetVersion="1">
+			<update-channel id="value">
+				<type>souliss:pressure</type>
+			</update-channel>
+		</instruction-set>
+	</thing-type>
+
+</update:update-descriptions>

From 1a90e315702d9fc12e5bef01cd852944e46650a4 Mon Sep 17 00:00:00 2001
From: Leo Siepel <leosiepel@gmail.com>
Date: Mon, 3 Nov 2025 19:29:40 +0100
Subject: [PATCH 2/2] Review comment

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
---
 .../src/main/resources/OH-INF/update/instructions.xml          | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/update/instructions.xml b/bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/update/instructions.xml
index cc6ef38bf2969..0bf8c12513924 100644
--- a/bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/update/instructions.xml
+++ b/bundles/org.openhab.binding.souliss/src/main/resources/OH-INF/update/instructions.xml
@@ -7,6 +7,7 @@
 		<instruction-set targetVersion="1">
 			<update-channel id="fire">
 				<type>souliss:buttonReadOnly</type>
+				<label>Fire</label>
 			</update-channel>
 		</instruction-set>
 	</thing-type>
@@ -15,6 +16,7 @@
 		<instruction-set targetVersion="1">
 			<update-channel id="statusAlarm">
 				<type>souliss:buttonReadOnly</type>
+				<label>Alarm Status</label>
 			</update-channel>
 		</instruction-set>
 	</thing-type>
@@ -23,6 +25,7 @@
 		<instruction-set targetVersion="1">
 			<update-channel id="statusAlarm">
 				<type>souliss:buttonReadOnly</type>
+				<label>Alarm Status</label>
 			</update-channel>
 		</instruction-set>
 	</thing-type>