From 6e5c4126008260b345fa0f2aeeb88ae1e598263c Mon Sep 17 00:00:00 2001 From: Holger Friedrich Date: Sun, 21 Dec 2025 13:56:44 +0100 Subject: [PATCH] [knx] Prevent reconfigutation of IP routers Follow-up to #19839. Discover separate Things for KNX IP routers and avoid setting IP address and port for routers. Routers use a defined multicast address. Make sure that Thing for router is separate, event if the same device exports a tunneling device. Signed-off-by: Holger Friedrich --- .../knx/internal/discovery/KNXnetDiscoveryService.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/discovery/KNXnetDiscoveryService.java b/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/discovery/KNXnetDiscoveryService.java index 70158d047d60f..01360855b740d 100644 --- a/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/discovery/KNXnetDiscoveryService.java +++ b/bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/discovery/KNXnetDiscoveryService.java @@ -119,11 +119,10 @@ private synchronized void startDiscovery() { } if (services.containsKey(ServiceFamiliesDIB.ServiceFamily.Routing)) { // .withProperty("type", "ROUTER") was omitted to avoid reconfiguration - thingDiscovered(DiscoveryResultBuilder.create(new ThingUID(THING_TYPE_IP_BRIDGE, serial)) + thingDiscovered(DiscoveryResultBuilder.create(new ThingUID(THING_TYPE_IP_BRIDGE, serial + "-r")) .withLabel(response.getDevice().getName() + " (router mode)") - .withProperty("serialNumber", serial + "-r").withProperty("ipAddress", "224.0.23.12") - .withProperty("port", "" + response.getControlEndpoint().endpoint().getPort()) - .withRepresentationProperty("serialNumber").build()); + .withProperty("serialNumber", serial + "-r").withRepresentationProperty("serialNumber") + .build()); } } else { logger.trace("Ignoring device {}", response);