From 1a7da1a2067018dc319e580a4f4e550e29c4b083 Mon Sep 17 00:00:00 2001 From: Jonathan Camarena Date: Sun, 28 Jul 2024 12:36:30 -0700 Subject: [PATCH 1/5] Removed dangling body tags from header and footer. Separated end scripts from footer into end.html --- _includes/shared/end.html | 15 ++++++ _includes/shared/footer.html | 18 ------- _includes/shared/header.html | 97 +++++++++++++++++++----------------- 3 files changed, 65 insertions(+), 65 deletions(-) create mode 100644 _includes/shared/end.html diff --git a/_includes/shared/end.html b/_includes/shared/end.html new file mode 100644 index 0000000..39b876a --- /dev/null +++ b/_includes/shared/end.html @@ -0,0 +1,15 @@ + + + + + + + + + diff --git a/_includes/shared/footer.html b/_includes/shared/footer.html index 322c02f..8c09f4c 100644 --- a/_includes/shared/footer.html +++ b/_includes/shared/footer.html @@ -20,21 +20,3 @@ - - - - - - - - - - - - diff --git a/_includes/shared/header.html b/_includes/shared/header.html index 7c1b4b9..03c633c 100644 --- a/_includes/shared/header.html +++ b/_includes/shared/header.html @@ -1,53 +1,56 @@ - +
-
- - - -
+
From 61aaafe94e02beedefab01e6bf4b82b3a8c6ff3a Mon Sep 17 00:00:00 2001 From: Jonathan Camarena Date: Sun, 28 Jul 2024 12:37:36 -0700 Subject: [PATCH 2/5] Fixed: moved header and footer into body. --- _layouts/default.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/_layouts/default.html b/_layouts/default.html index d3f34e1..eed25a0 100644 --- a/_layouts/default.html +++ b/_layouts/default.html @@ -3,9 +3,8 @@ {% include "shared/head.html" %} - {% include "shared/header.html" %} - + {% include "shared/header.html" %}
@@ -21,5 +20,6 @@

{{ title }}

{% include "shared/footer.html" %} + {% include "shared/end.html" %} From 91760882236c1717f492604f10a90406b3b72d35 Mon Sep 17 00:00:00 2001 From: Jonathan Camarena Date: Sun, 28 Jul 2024 12:38:42 -0700 Subject: [PATCH 3/5] Fixed: erroneous backlinks from skills tab. --- _layouts/skills.html | 33 ++++++++++++++++++++++++--------- 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/_layouts/skills.html b/_layouts/skills.html index 483ba23..60c819b 100644 --- a/_layouts/skills.html +++ b/_layouts/skills.html @@ -1,5 +1,8 @@ + +{% include "shared/head.html" %} + @@ -9,23 +12,35 @@ + + - - + +
+ {% include "shared/header.html" %} +
+ + + + From ddfe17a0aff2ec95972b2cc3bec08748af6bd0eb Mon Sep 17 00:00:00 2001 From: Jonathan Camarena Date: Sun, 28 Jul 2024 13:10:41 -0700 Subject: [PATCH 4/5] Added end.html and fixed footer/header positioning in layouts. --- _layouts/codeofconduct.html | 6 ++++-- _layouts/default.html | 2 +- _layouts/home.html | 2 ++ _layouts/skills.html | 2 +- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/_layouts/codeofconduct.html b/_layouts/codeofconduct.html index 1c33980..a4c3bc0 100644 --- a/_layouts/codeofconduct.html +++ b/_layouts/codeofconduct.html @@ -3,10 +3,10 @@ {% include "shared/head.html" %} - {% include "shared/header.html" %} - + {% include "shared/header.html" %} +
@@ -21,4 +21,6 @@ + {% include "shared/end.html" %} + diff --git a/_layouts/default.html b/_layouts/default.html index eed25a0..ac0b60c 100644 --- a/_layouts/default.html +++ b/_layouts/default.html @@ -1,7 +1,7 @@ -{% include "shared/head.html" %} + {% include "shared/head.html" %} {% include "shared/header.html" %} diff --git a/_layouts/home.html b/_layouts/home.html index 7cd00ee..1078cbd 100644 --- a/_layouts/home.html +++ b/_layouts/home.html @@ -17,4 +17,6 @@ {% include "shared/footer.html" %} + {% include "shared/end.html" %} + diff --git a/_layouts/skills.html b/_layouts/skills.html index 60c819b..3e17114 100644 --- a/_layouts/skills.html +++ b/_layouts/skills.html @@ -40,7 +40,7 @@ - + {% include "shared/end.html" %} From 34f73244dfcef9db4a73f1b3e92c99d0d42a2aa4 Mon Sep 17 00:00:00 2001 From: Jonathan Camarena Date: Sun, 28 Jul 2024 13:18:30 -0700 Subject: [PATCH 5/5] fix: moved iframe content 10px to ensure its fully concealed. --- _layouts/skills.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_layouts/skills.html b/_layouts/skills.html index 3e17114..b020ff3 100644 --- a/_layouts/skills.html +++ b/_layouts/skills.html @@ -23,7 +23,7 @@ left: 0; right: 0; bottom: 0; - top: 0; + top: -10px; border: 0; }