-
Notifications
You must be signed in to change notification settings - Fork 49
Open
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.
Description
We are behind on carrying upstream library changes for templates, but make content is currently broken due to an upstream change removing the indices we rely on: openshift/library#222 (comment)
openshift-azure/pkg/sync/v19/content_test.go
Lines 256 to 277 in 4205d73
| func TestContent(t *testing.T) { | |
| b, err := get("https://github.com/openshift/library/raw/master/official/index.json") | |
| if err != nil { | |
| t.Fatal(err) | |
| } | |
| var index index | |
| err = json.Unmarshal(b, &index) | |
| if err != nil { | |
| t.Fatal(err) | |
| } | |
| err = handleImageStreams(index) | |
| if err != nil { | |
| t.Fatal(err) | |
| } | |
| err = handleTemplates(index) | |
| if err != nil { | |
| t.Fatal(err) | |
| } | |
| } |
I'd like to incorporate some of the content update changes, but I'm not sure which changes are safe to carry vs which are not. See also #2275 (comment) where I noted the new imagestream updates were consistently breaking e2e.
/kind bug
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.