Drop duplicate test making real network calls

Author: joshbranham

internal/utils/network_test.go

@@ -10,53 +10,6 @@ import (
 	log "github.com/sirupsen/logrus"
 )
 
-func ExampleIsOnline() {
-	google, _ := url.Parse("https://google.com")
-	err := IsOnline(*google)
-
-	if err != nil {
-		fmt.Println("Host is not accessible")
-	} else {
-		fmt.Println("Host is accessible")
-	}
-	// Output: Host is accessible
-}
-
-func setUpMock(scenario string) *httptest.Server {
-	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		switch scenario {
-		case "OK":
-			w.WriteHeader(http.StatusOK)
-			_, _ = fmt.Fprintln(w, "OK")
-			return
-		case "Accepted":
-			w.WriteHeader(http.StatusAccepted)
-			_, _ = fmt.Fprintln(w, "Accepted")
-			return
-		case "Redirect":
-			http.Redirect(w, r, "https://google.com", http.StatusMovedPermanently)
-			return
-		case "BadRequest":
-			http.Error(w, http.StatusText(http.StatusBadRequest), http.StatusBadRequest)
-			return
-		case "NotFound":
-			http.Error(w, http.StatusText(http.StatusNotFound), http.StatusNotFound)
-			return
-		case "RateLimit":
-			http.Error(w, http.StatusText(http.StatusTooManyRequests), http.StatusTooManyRequests)
-			return
-		case "ServerError":
-			http.Error(w, http.StatusText(http.StatusInternalServerError), http.StatusNotFound)
-			return
-		default:
-			log.Fatalf("Unimplemented scenario %q provided", scenario)
-			return
-		}
-	}))
-
-	return ts
-}
-
 func Test_IsOnline(t *testing.T) {
 	tests := []struct {
 		name     string
@@ -114,11 +67,45 @@ func Test_IsOnline(t *testing.T) {
 	}
 }
 
-func Test_IsOnline_MissingHost(t *testing.T) {
-	testURL, _ := url.Parse("https://does-not-exist.github.com")
+func setUpMock(scenario string) *httptest.Server {
+	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		// Handle redirect target path
+		if scenario == "Redirect" && r.URL.Path == "/redirected" {
+			w.WriteHeader(http.StatusOK)
+			_, _ = fmt.Fprintln(w, "Redirected successfully")
+			return
+		}
 
-	err := IsOnline(*testURL)
-	if (err != nil) != true {
-		t.Errorf("IsOnline(%q) error = %v, wantErr %v", testURL.String(), err, true)
-	}
+		switch scenario {
+		case "OK":
+			w.WriteHeader(http.StatusOK)
+			_, _ = fmt.Fprintln(w, "OK")
+			return
+		case "Accepted":
+			w.WriteHeader(http.StatusAccepted)
+			_, _ = fmt.Fprintln(w, "Accepted")
+			return
+		case "Redirect":
+			// Redirect to the same mock server to avoid external calls
+			http.Redirect(w, r, "/redirected", http.StatusMovedPermanently)
+			return
+		case "BadRequest":
+			http.Error(w, http.StatusText(http.StatusBadRequest), http.StatusBadRequest)
+			return
+		case "NotFound":
+			http.Error(w, http.StatusText(http.StatusNotFound), http.StatusNotFound)
+			return
+		case "RateLimit":
+			http.Error(w, http.StatusText(http.StatusTooManyRequests), http.StatusTooManyRequests)
+			return
+		case "ServerError":
+			http.Error(w, http.StatusText(http.StatusInternalServerError), http.StatusNotFound)
+			return
+		default:
+			log.Fatalf("Unimplemented scenario %q provided", scenario)
+			return
+		}
+	}))
+
+	return ts
 }