Skip to content

Commit afdcd00

Browse files
loneilloneil
committed
Remove OOB and URL config options
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
1 parent 55fc9c9 commit afdcd00

File tree

8 files changed

+6
-61
lines changed

8 files changed

+6
-61
lines changed

‎charts/vc-authn-oidc/README.md‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,7 @@ kubectl delete secret,pvc --selector "app.kubernetes.io/instance"=my-release
9494
| `acapyTenancyMode` | Agent tenancy mode, either `single` or `multi` | `single` |
9595
| `setNonRevoked` | if True, the `non_revoked` attributed will be added to each of the present-proof request `requested_attribute` and `requested_predicate` with 'from=0' and'to=`int(time.time())` | `true` |
9696
| `invitationLabel` | For the invitations sent that include the proof, what to add as the my_label field. Can be used to identify the requester to the prover | `VC-AuthN` |
97-
| `useOobPresentProof` | if True, the present-proof request will be provided as a an [out of band](https://github.com/hyperledger/aries-rfcs/tree/main/features/0434-outofband) invitation with a [present-proof](https://github.com/hyperledger/aries-rfcs/tree/main/features/0037-present-proof) request inside. If False, the present-proof request will be use the [service-decorator](https://github.com/hyperledger/aries-rfcs/tree/main/features/0056-service-decorator) | `false` |
9897
| `useOobLocalDIDService` | | `false` |
99-
| `useUrlDeepLink` | if True, will use the new encoded URL (e.g. bcwallet://aries_proof-request?_url={redirect URL}) redirect form of the deep link | `false` |
10098
| `walletDeepLinkPrefix` | URI scheme and host to use in deep links ((e.g. `{WALLET_DEEP_LINK_PREFIX}?c_i={connection invitation payload`)) | `bcwallet://aries_proof-request` |
10199
| `controller.cameraRedirectUrl` | The redirect url can be a web link or the name of a template | `wallet_howto` |
102100
| `controller.presentationExpireTime` | The number of time in seconds a proof request will be valid for | `300` |

‎charts/vc-authn-oidc/templates/deployment.yaml‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -91,10 +91,6 @@ spec:
9191
value: {{ include "acapy.internal.admin.url" . }}
9292
- name: INVITATION_LABEL
9393
value: {{ .Values.invitationLabel | quote }}
94-
- name: USE_OOB_PRESENT_PROOF
95-
value: {{ .Values.useOobPresentProof | quote }}
96-
- name: USE_URL_DEEP_LINK
97-
value: {{ .Values.useUrlDeepLink | quote }}
9894
- name: WALLET_DEEP_LINK_PREFIX
9995
value: {{ .Values.walletDeepLinkPrefix }}
10096
- name: SET_NON_REVOKED

‎charts/vc-authn-oidc/values.yaml‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,12 +28,8 @@ acapyTenancyMode: single
2828
setNonRevoked: true
2929
## @param invitationLabel For the invitations sent that include the proof, what to add as the my_label field. Can be used to identify the requester to the prover
3030
invitationLabel: VC-AuthN
31-
## @param useOobPresentProof if True, the present-proof request will be provided as a an [out of band](https://github.com/hyperledger/aries-rfcs/tree/main/features/0434-outofband) invitation with a [present-proof](https://github.com/hyperledger/aries-rfcs/tree/main/features/0037-present-proof) request inside. If False, the present-proof request will be use the [service-decorator](https://github.com/hyperledger/aries-rfcs/tree/main/features/0056-service-decorator)
32-
useOobPresentProof: false
3331
## @param useOobLocalDIDService
3432
useOobLocalDIDService: false
35-
## @param useUrlDeepLink if True, will use the new encoded URL (e.g. bcwallet://aries_proof-request?_url={redirect URL}) redirect form of the deep link
36-
useUrlDeepLink: false
3733
## @param walletDeepLinkPrefix URI scheme and host to use in deep links ((e.g. `{WALLET_DEEP_LINK_PREFIX}?c_i={connection invitation payload`))
3834
walletDeepLinkPrefix: bcwallet://aries_proof-request
3935
## @param controller.cameraRedirectUrl The redirect url can be a web link or the name of a template

‎docker/docker-compose.yaml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ services:
3535
- MT_ACAPY_WALLET_KEY=${MT_ACAPY_WALLET_KEY}
3636
- ST_ACAPY_ADMIN_API_KEY=${AGENT_ADMIN_API_KEY}
3737
- ST_ACAPY_ADMIN_API_KEY_NAME=${ST_ACAPY_ADMIN_API_KEY_NAME}
38-
- USE_OOB_PRESENT_PROOF=${USE_OOB_PRESENT_PROOF}
3938
- USE_OOB_LOCAL_DID_SERVICE=${USE_OOB_LOCAL_DID_SERVICE}
40-
- USE_URL_DEEP_LINK=${USE_URL_DEEP_LINK}
4139
- WALLET_DEEP_LINK_PREFIX=${WALLET_DEEP_LINK_PREFIX}
4240
- INVITATION_LABEL=${INVITATION_LABEL}
4341
ports:

‎docker/manage‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,9 +188,7 @@ configureEnvironment() {
188188
#controller app settings
189189
export INVITATION_LABEL=${INVITATION_LABEL:-"VC-AuthN"}
190190
export SET_NON_REVOKED="True"
191-
export USE_OOB_PRESENT_PROOF=${USE_OOB_PRESENT_PROOF:-"true"}
192191
export USE_OOB_LOCAL_DID_SERVICE=${USE_OOB_LOCAL_DID_SERVICE:-"true"}
193-
export USE_URL_DEEP_LINK=${USE_URL_DEEP_LINK:-"false"}
194192
export WALLET_DEEP_LINK_PREFIX=${WALLET_DEEP_LINK_PREFIX:-"bcwallet://aries_proof-request"}
195193

196194
# agent

‎docs/ConfigurationGuide.md‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,7 @@ Several functions in ACAPy VC-AuthN can be tweaked by using the following enviro
7777
| Variable | Type | What it does | NOTES |
7878
| ------------------------- | -------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | --------------------------------------------------------------------------------------------------------------------------------------- |
7979
| SET_NON_REVOKED | bool | if True, the `non_revoked` attributed will be added to each of the present-proof request `requested_attribute` and `requested_predicate` with 'from=0' and'to=`int(time.time())` | |
80-
| USE_OOB_PRESENT_PROOF | bool | if True, the present-proof request will be provided as a an [out of band](https://github.com/hyperledger/aries-rfcs/tree/main/features/0434-outofband) invitation with a [present-proof](https://github.com/hyperledger/aries-rfcs/tree/main/features/0037-present-proof) request inside. If False, the present-proof request will be use the [service-decorator](https://github.com/hyperledger/aries-rfcs/tree/main/features/0056-service-decorator) | **TRUE:** BC Wallet supports our OOB Message, BiFold, Lissi, Trinsic, and Estatus all read the QR code as 'Invalid' |
81-
| USE_OOB_LOCAL_DID_SERVICE | bool | Instructs ACAPy VC-AuthN to use a local DID, it must be used when the agent service is not registered on the ledger with a public DID | Use this when `ACAPY_WALLET_LOCAL_DID` is set to `true` in the agent. |
82-
| USE_URL_DEEP_LINK | bool | If True, in Mobile mode the BC Wallet deep link will use an encoded URL (`WALLET_DEEP_LINK_PREFIX?_url={redirect URL}`), otherwise will use the encoded connection invitation (`{WALLET_DEEP_LINK_PREFIX}?c_i={connection invitation payload}`) | Default False/.. To control using the `?_url` handler |
80+
| USE_OOB_LOCAL_DID_SERVICE | bool | Instructs ACAPy VC-AuthN to use a local DID, it must be used when the agent service is not registered on the ledger with a public DID | Use this when `ACAPY_WALLET_LOCAL_DID` is set to `true` in the agent. |
8381
| WALLET_DEEP_LINK_PREFIX | string | Custom URI scheme and host to use for deep links (e.g. `{WALLET_DEEP_LINK_PREFIX}?c_i={connection invitation payload`) | Default bcwallet://aries_proof-request |
8482
| LOG_WITH_JSON | bool | If True, logging output should printed as JSON if False it will be pretty printed. | Default behavior will print as JSON. |
8583
| LOG_TIMESTAMP_FORMAT | string | determines the timestamp formatting used in logs | Default is "iso" |

‎oidc-controller/api/core/config.py‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -218,13 +218,9 @@ class GlobalConfig(BaseSettings):
218218
# OIDC Controller Settings
219219
INVITATION_LABEL: str = os.environ.get("INVITATION_LABEL", "VC-AuthN")
220220
CONTROLLER_API_KEY: str = os.environ.get("CONTROLLER_API_KEY", "")
221-
USE_OOB_PRESENT_PROOF: bool = strtobool(
222-
os.environ.get("USE_OOB_PRESENT_PROOF", False)
223-
)
224221
USE_OOB_LOCAL_DID_SERVICE: bool = strtobool(
225222
os.environ.get("USE_OOB_LOCAL_DID_SERVICE", True)
226223
)
227-
USE_URL_DEEP_LINK: bool = strtobool(os.environ.get("USE_URL_DEEP_LINK", False))
228224
WALLET_DEEP_LINK_PREFIX: str = os.environ.get(
229225
"WALLET_DEEP_LINK_PREFIX", "bcwallet://aries_proof-request"
230226
)

0 commit comments

Comments
 (0)