add unit test for increased coverage

Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>

Author: PatStLouis

acapy_agent/anoncreds/revocation/tests/test_revocation.py

@@ -1046,6 +1046,87 @@ async def test_decommission_registry_new_backup_creation_fails(self, mock_handle
         assert len(result) == 2
         assert result[0].tags["state"] == RevRegDefState.STATE_DECOMMISSIONED
 
+    @mock.patch.object(AskarAnonCredsProfileSession, "handle")
+    async def test_decommission_registry_duplicate_store_handled(self, mock_handle):
+        """When event chain already stored the registry, duplicate is handled gracefully."""
+        mock_handle.fetch_all = mock.CoroutineMock(
+            side_effect=[
+                [
+                    MockEntry(
+                        name="backup-reg-reg",
+                        tags={
+                            "cred_def_id": "test-rev-reg-def-id",
+                            "state": RevRegDefState.STATE_FINISHED,
+                            "active": "false",
+                        },
+                    ),
+                ],
+                [
+                    MockEntry(
+                        name="active-reg-reg",
+                        tags={
+                            "cred_def_id": "test-rev-reg-def-id",
+                            "state": RevRegDefState.STATE_FINISHED,
+                            "active": "true",
+                        },
+                    ),
+                    MockEntry(
+                        name="backup-reg-reg",
+                        tags={
+                            "cred_def_id": "test-rev-reg-def-id",
+                            "state": RevRegDefState.STATE_FINISHED,
+                            "active": "false",
+                        },
+                    ),
+                    MockEntry(
+                        name="new-rev-reg",
+                        tags={
+                            "cred_def_id": "test-rev-reg-def-id",
+                            "state": RevRegDefState.STATE_FINISHED,
+                            "active": "false",
+                        },
+                    ),
+                ],
+            ]
+        )
+        self.revocation.get_or_create_active_registry = mock.CoroutineMock(
+            return_value=RevRegDefResult(
+                job_id="test-job-id",
+                revocation_registry_definition_state=RevRegDefState(
+                    state=RevRegDefState.STATE_FINISHED,
+                    revocation_registry_definition_id="active-reg-reg",
+                    revocation_registry_definition=rev_reg_def,
+                ),
+                registration_metadata={},
+                revocation_registry_definition_metadata={},
+            )
+        )
+        self.revocation.create_and_register_revocation_registry_definition = (
+            mock.CoroutineMock(
+                return_value=RevRegDefResult(
+                    job_id="test-job-id",
+                    revocation_registry_definition_state=RevRegDefState(
+                        state=RevRegDefState.STATE_ACTION,
+                        revocation_registry_definition_id="new-rev-reg",
+                        revocation_registry_definition=rev_reg_def,
+                    ),
+                    registration_metadata={},
+                    revocation_registry_definition_metadata={},
+                )
+            )
+        )
+        self.revocation.store_revocation_registry_definition = mock.CoroutineMock(
+            side_effect=test_module.AnonCredsRevocationError("Duplicate entry")
+        )
+        self.revocation.set_active_registry = mock.CoroutineMock(return_value=None)
+        mock_handle.replace = mock.CoroutineMock(return_value=None)
+
+        result = await self.revocation.decommission_registry("test-rev-reg-def-id")
+
+        assert isinstance(result, list)
+        self.revocation.store_revocation_registry_definition.assert_called_once()
+        self.revocation.set_active_registry.assert_called_once_with("backup-reg-reg")
+
     @mock.patch.object(AskarAnonCredsProfileSession, "handle")
     async def test_get_backup_registry_id_raises_when_no_backup(self, mock_handle):
         """_get_backup_registry_id raises when no finished backup exists."""

acapy_agent/anoncreds/routes/revocation/registry/tests/test_routes.py

@@ -11,11 +11,12 @@
 from .....issuer import AnonCredsIssuer
 from .....models.issuer_cred_rev_record import IssuerCredRevRecord
 from .....models.revocation import RevRegDef, RevRegDefState, RevRegDefValue
-from .....revocation import AnonCredsRevocation
+from .....revocation import AnonCredsRevocation, AnonCredsRevocationError
 from .....tests.mock_objects import MockRevocationRegistryDefinition
 from ....common.testing import BaseAnonCredsRouteTestCase
 from .. import routes as test_module
 from ..routes import (
+    get_active_rev_reg,
     get_rev_reg_issued,
     get_rev_reg_issued_count,
     get_rev_regs,
@@ -178,6 +179,16 @@ async def test_active_registry_wrong_profile_403(self):
         with self.assertRaises(web.HTTPForbidden):
             await set_active_registry(self.request)
 
+    @mock.patch.object(
+        AnonCredsRevocation,
+        "get_or_create_active_registry",
+        side_effect=AnonCredsRevocationError("No active registry"),
+    )
+    async def test_get_active_rev_reg_not_found(self, mock_get):
+        self.request.match_info = {"cred_def_id": "test_cred_def_id"}
+        with self.assertRaises(web.HTTPNotFound):
+            await get_active_rev_reg(self.request)
+
     async def test_get_rev_regs(self):
         self.request.query = {
             "cred_def_id": "test_cred_def_id",