Merge pull request #4052 from OpSecId/fix-bdd-tests

FIX BDD interop integration tests

Author: PatStLouis

.github/workflows/bdd-interop-tests.yml

@@ -66,7 +66,7 @@ jobs:
       - name: Prepare Interop Tests
         if: (steps.check-if-src-changed.outputs.run_tests != 'false' || steps.check_if_release.outputs.is_release == 'true' || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch')
         run: |
-          # Get AATH 
+          # Get AATH
           git clone https://github.com/openwallet-foundation/owl-agent-test-harness.git
 
           # Change fork and branch for pull requests
@@ -83,27 +83,32 @@ jobs:
         if: (steps.check_if_release.outputs.is_release != 'true' && github.event_name == 'pull_request' && steps.check-if-src-changed.outputs.run_tests != 'false')
         run: |
           cd owl-agent-test-harness
-          NO_TTY=1 LEDGER_URL_CONFIG=https://test.bcovrin.vonx.io TAILS_SERVER_URL_CONFIG=https://tails.vonx.io ./manage run -d acapy-main -t @critical -t ~@wip -t ~@T004-RFC0211 -t ~@DidMethod_orb -t ~@Transport_NoHttpOutbound -t ~@Anoncreds >> output.txt
+          LEDGER_TIMEOUT=180 NO_TTY=1 LEDGER_URL_CONFIG=https://test.bcovrin.vonx.io TAILS_SERVER_URL_CONFIG=https://tails.vonx.io ./manage run -d acapy-main -t @critical -t ~@wip -t ~@T004-RFC0211 -t ~@DidMethod_orb -t ~@Transport_NoHttpOutbound -t ~@Anoncreds 2>&1 | tee output.txt
       - name: Run Release or Nightly Interop Tests Indy
         if: (steps.check_if_release.outputs.is_release == 'true' || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' && steps.check-if-src-changed.outputs.run_tests != 'false')
         run: |
           cd owl-agent-test-harness
-          NO_TTY=1 LEDGER_URL_CONFIG=https://test.bcovrin.vonx.io TAILS_SERVER_URL_CONFIG=https://tails.vonx.io ./manage run -d acapy-main -t @critical -t ~@wip -t ~@T004-RFC0211 -t ~@DidMethod_orb -t ~@Transport_NoHttpOutbound -t ~@Anoncreds >> output.txt
+          LEDGER_TIMEOUT=180 NO_TTY=1 LEDGER_URL_CONFIG=https://test.bcovrin.vonx.io TAILS_SERVER_URL_CONFIG=https://tails.vonx.io ./manage run -d acapy-main -t @critical -t ~@wip -t ~@T004-RFC0211 -t ~@DidMethod_orb -t ~@Transport_NoHttpOutbound -t ~@Anoncreds 2>&1 | tee output.txt
       - name: Run Release or Nightly Interop Tests AnonCreds
         if: (steps.check_if_release.outputs.is_release == 'true' || github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' && steps.check-if-src-changed.outputs.run_tests != 'false')
         run: |
           cd owl-agent-test-harness
-          BACKCHANNEL_EXTRA_acapy_main="{\"wallet-type\":\"askar-anoncreds\"}" NO_TTY=1 LEDGER_URL_CONFIG=https://test.bcovrin.vonx.io TAILS_SERVER_URL_CONFIG=https://tails.vonx.io ./manage run -d acapy-main -t @AcceptanceTest -t ~@wip -t ~@T004-RFC0211 -t ~@DidMethod_orb -t ~@Transport_NoHttpOutbound -t ~@Indy -t ~@CredFormat_Indy >> output.txt
+          LEDGER_TIMEOUT=180 BACKCHANNEL_EXTRA_acapy_main="{\"wallet-type\":\"askar-anoncreds\"}" NO_TTY=1 LEDGER_URL_CONFIG=https://test.bcovrin.vonx.io TAILS_SERVER_URL_CONFIG=https://tails.vonx.io ./manage run -d acapy-main -t @AcceptanceTest -t ~@wip -t ~@T004-RFC0211 -t ~@DidMethod_orb -t ~@Transport_NoHttpOutbound -t ~@Indy -t ~@CredFormat_Indy 2>&1 | tee output.txt
       - name: Check If Tests Failed
-        if: steps.check-if-src-changed.outputs.run_tests != 'false'
+        if: always() && (steps.check-if-src-changed.outputs.run_tests != 'false')
         run: |
           cd owl-agent-test-harness
-          cat output.txt
-          if grep "Failing scenarios:" output.txt; then
-              echo "Tests failed"
-              exit 1
+          if [ -f output.txt ]; then
+            cat output.txt
+            if grep "Failing scenarios:" output.txt; then
+                echo "Tests failed"
+                exit 1
+            else
+                echo "Tests passed"
+                exit 0
+            fi
           else
-              echo "Tests passed"
-              exit 0
+            echo "No output file found - tests may not have run"
+            exit 1
           fi
 

acapy_agent/config/logging/configurator.py

@@ -377,13 +377,15 @@ def print_notices(cls, settings: Settings):
                 )
                 banner.hr()
                 banner.print(
-                    "Aries RFC 0036: Issue Credential 1.0 is deprecated "
-                    "and support will be removed in a future release; "
-                    "use RFC 0453: Issue Credential 2.0 instead."
+                    "Aries RFC 0036: Issue Credential 1.0 has been removed "
+                    "from ACA-Py core. To continue using this protocol, "
+                    "enable the issue-credential plugin from "
+                    "https://github.com/openwallet-foundation/acapy-plugins"
                 )
                 banner.hr()
                 banner.print(
-                    "Aries RFC 0037: Present Proof 1.0 is deprecated "
-                    "and support will be removed in a future release; "
-                    "use RFC 0454: Present Proof 2.0 instead."
+                    "Aries RFC 0037: Present Proof 1.0 has been removed "
+                    "from ACA-Py core. To continue using this protocol, "
+                    "enable the present-proof plugin from "
+                    "https://github.com/openwallet-foundation/acapy-plugins"
                 )