Discrepencies between anoncreds events and indy events

[PatStLouis]

After investigating event subscriptions for upgraded wallets, I noticed the following:

• AnonCreds events are sent as a named tuple payload, whilst indy events are sent as a dict payload with a context key.
• AnonCreds event for finished schema creation is missing
• AnonCreds event for finished cred def creation is missing the tag

Questions I have:

• Why was the format of the event changed, what benefit does NamedTuple have over a dictionary?
• Why was no finished schema creation event included?
• Why was the cred def tag not included in the AnonCreds event?

If I'm mistaken please let me know.

[swcurran]

I would say this pretty urgent to address, given the desire to deprecate the askar wallet type. I don't know why the first change was made, but assume there is a reason -- even though it is frustrating. The last two certainly look like bugs to me, and so should be addressed as soon as possible. Is there any other way to get the status of the schema created and the tag?

Can you put a link in as to where these are in the code? Nice to have pointers to both the indy and anoncreds code.

[PatStLouis]

I've addressed point 2 and 3 in this PR: #4016

The schema create will now trigger a notification event when finished, and the cred def event will include the tag.

The format of the events can be discussed further and addressed in a subsequent PR if need be.

Indy events are defined in the messaging module. Here is the cred def event payload construction:

acapy/acapy_agent/messaging/credential_definitions/routes.py

Line 317 in 783966b

meta_data = {

Anoncreds events are defined in the anoncreds issuer module:

acapy/acapy_agent/anoncreds/issuer.py

Line 473 in 783966b

await self.notify(

We can see that the notify function is called with the NamedTuple directly in the anoncreds module, whilst the notify function is called with a meta_data dict in the indy module.

[swcurran]

First item is left as ¯\_(ツ)_/¯. Last two are fixed. Closing.