Identity details screen increases in size vertically each time different sort options are selected

[CLBRITTON2]

Description:
While testing identity details scrolling with anywhere from 49-200 services it seems that sorting by name/address/protocol/port and ascending/descending will cause the UI to start resizing unexpectedly. This happened building locally from main branch and using the latest release executable 2.9.3.0.

Environment: Windows 11 home version 10.0.26200

Steps to reproduce:

• Make > 50 services for an identity (it also seems to happen with less than 50)
• Enter the details screen
• Select random sorting options
• The UI starts to increase in size vertically each sort

[dovholuknf]

Thanks for the steps to reproduce. I wasn't actually able to replicate the problem. For me it would continually crash the UI. You were able to sort successfully, any exrta details you could share? I don't even get an error caputred in the UI when it crashes. :/

[dovholuknf]

Event Viewer reports the problem:

Application: ZitiDesktopEdge.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: System.NullReferenceException
   at ZitiDesktopEdge.IdentityDetails+<>c.<UpdateView>b__88_2(ZitiDesktopEdge.Models.ZitiService)
   at System.Linq.EnumerableSorter`2[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089],[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].ComputeKeys(System.__Canon[], Int32)
   at System.Linq.EnumerableSorter`1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].Sort(System.__Canon[], Int32)
   at System.Linq.OrderedEnumerable`1+<GetEnumerator>d__1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]].MoveNext()
   at System.Linq.Buffer`1[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]]..ctor(System.Collections.Generic.IEnumerable`1<System.__Canon>)
   at System.Linq.Enumerable.ToArray[[System.__Canon, mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089]](System.Collections.Generic.IEnumerable`1<System.__Canon>)
   at ZitiDesktopEdge.IdentityDetails.UpdateView()
   at ZitiDesktopEdge.Filter.SortByChanged(System.Object, System.Windows.Controls.SelectionChangedEventArgs)

[CLBRITTON2]

I was actually trying to reproduce #823 when I came across this and I'm not sure if it's just how I've set up services for testing.
I run quickstart locally and a modified version of the setup-ids-for-test.ps1 that creates a loop to make X number of dupe services for an identity inside function createNormalUsers
Instead of:

    $name="normal-user-01"
    ziti edge create identity $name -o "$identityDir\$name.jwt"
    makeTestService $name "0"

I do something like:

    $name="normal-user-01"
    ziti edge create identity $name -o "$identityDir\$name.jwt"
    for ($i = 0; $i -lt 54; $i++) {
        $ordinal = "{0:D2}" -f $i
        makeTestService $name $ordinal
    }

I'm not sure if this has implications on how the identity details are handled in terms of crashing the UI...

I was thinking that IdentityDetails.xaml.cs Scrolled() along with some of the logic in UpdateView() was causing a logic war between how observable collections are treated in WPF and the code behind when items are added/removed.

Each time UpdateView() is called the observable collection bound to that ServiceList is recreated and the ItemsSource is reset.
I'm not sure if that's what might be causing the null ref? Maybe a race condition?

I've stopped the resizing in two ways locally.
1 was to completely remove the Scrolled logic and anything pertaining to paginated scrolling. I let the ServiceList just have the entire collection of services go straight to the UI and that was it. The downside I guess is a tiny scroll bar if you have a ton of services?
2 was to simplify the scrolled functionality and stop trying to programmatically resize anything dealing with the list view.

Since I'm unable to reproduce the UI crash I have to be missing something. Or the issues aren't really related and this is just a problem relating to how collections/refreshes are interacting.

[CLBRITTON2]

Ok so I was able to reproduce the crash by making a service with no addresses/ports/protocols and attempting to sort by one of those 3 fields.
The sorting logic doesn't have a null check it just expects a name/address/protocol/port to be present.

desktop-edge-win/DesktopEdge/Views/Screens/IdentityDetails.xaml.cs

Lines 266 to 270 in 269e634

	if (SortBy == "Name") services = _identity.Services.OrderBy(s => s.Name.ToLower()).ToArray();
	else if (SortBy == "Address") services = _identity.Services.OrderBy(s => s.Addresses.ToString()).ToArray();
	else if (SortBy == "Protocol") services = _identity.Services.OrderBy(s => s.Protocols.ToString()).ToArray();
	else if (SortBy == "Port") services = _identity.Services.OrderBy(s => s.Ports.ToString()).ToArray();
	if (SortWay == "Desc") services = services.Reverse().ToArray();