Update frontend code to not use identifier anymore

Author: gmazoyer

frontend/app/src/entities/role-manager/api/getGlobalPermissions.ts

@@ -24,9 +24,6 @@ export const GET_ROLE_MANAGEMENT_GLOBAL_PERMISSIONS = graphql(`
               }
             }
           }
-          identifier {
-            value
-          }
           __typename
         }
       }

frontend/app/src/entities/role-manager/api/getObjectPermissions.ts

@@ -30,9 +30,6 @@ export const GET_ROLE_MANAGEMENT_OBJECT_PERMISSIONS = graphql(`
               }
             }
           }
-          identifier {
-            value
-          }
         }
       }
       permissions {

frontend/app/src/entities/role-manager/api/getRoles.ts

@@ -27,9 +27,6 @@ export const GET_ROLE_MANAGEMENT_ROLES = graphql(`
               node {
                 id
                 display_label
-                identifier {
-                  value
-                }
               }
             }
           }

frontend/app/src/entities/role-manager/ui/global-permissions.tsx

@@ -62,8 +62,8 @@ function GlobalPermissions() {
 
   const columns = [
     {
-      name: "identifier",
-      label: "Identifier",
+      name: "display_label",
+      label: "Label",
     },
     {
       name: "action",
@@ -85,7 +85,6 @@ function GlobalPermissions() {
       return {
         values: {
           id: edge?.node?.id,
-          display_label: edge?.node?.display_label,
           hfid: edge?.node?.hfid,
           action: { value: edge?.node?.action?.value },
           decision: {
@@ -105,9 +104,9 @@ function GlobalPermissions() {
             ),
             value: { edges: edge?.node?.roles?.edges },
           },
-          identifier: {
-            value: edge?.node?.identifier?.value,
-            display: <BadgeCopy value={edge?.node?.identifier?.value} />,
+          display_label: {
+            value: edge?.node?.display_label,
+            display: <BadgeCopy value={edge?.node?.display_label} />,
           },
           __typename: edge.node.__typename,
         },
@@ -192,7 +191,7 @@ function GlobalPermissions() {
           title={
             <SlideOverTitle
               schema={schema}
-              currentObjectLabel={rowToUpdate?.identifier?.value ?? "New"}
+              currentObjectLabel={rowToUpdate?.display_label?.value ?? "New"}
               title={`${rowToUpdate ? "Update" : "Create"} ${schema.label}`}
               subtitle={schema.description}
             />

frontend/app/src/entities/role-manager/ui/object-permissions.tsx

@@ -77,8 +77,8 @@ function Permissions() {
 
   const columns = [
     {
-      name: "identifier",
-      label: "Identifier",
+      name: "display_label",
+      label: "Label",
     },
     {
       name: "namespace",
@@ -111,7 +111,6 @@ function Permissions() {
       return {
         values: {
           id: edge?.node?.id,
-          display_label: edge?.node?.display_label,
           hfid: edge?.node?.hfid,
           display: {
             value: edge?.node ? getNodeLabel(edge.node) : undefined,
@@ -147,9 +146,9 @@ function Permissions() {
               />
             ),
           },
-          identifier: {
-            value: edge?.node?.identifier?.value,
-            display: <BadgeCopy value={edge?.node?.identifier?.value} />,
+          display_label: {
+            value: edge?.node?.display_label,
+            display: <BadgeCopy value={edge?.node?.display_label} />,
           },
           __typename: edge?.node?.__typename,
         },

frontend/app/src/entities/role-manager/ui/permission-combobox.tsx

@@ -23,16 +23,15 @@ import { AddRelationshipAction } from "@/entities/nodes/relationships/ui/add-rel
 import type { NodeCore } from "@/entities/nodes/types";
 import { useSchema } from "@/entities/schema/ui/hooks/useSchema";
 
-type PermissionNode = NodeCore & { identifier: { value: string } };
+type PermissionNode = NodeCore;
 
 export interface PermissionComboboxProps extends Omit<PopoverTriggerProps, "value" | "onChange"> {
   value: PermissionNode[] | null;
   onChange: (value: PermissionNode[]) => void;
 }
 
-// This component is a temporary solution to display the permissions in a combobox
-// We cannot use relationship many because the general beheviour is to use hfid/display_label
-// On permission, label is it an attribute called identifier
+// This component is used to display the permissions in a combobox
+// It uses display_label like other relationship pickers
 export function PermissionCombobox({
   value,
   onChange,
@@ -59,7 +58,7 @@ export function PermissionCombobox({
           <div className="flex grow flex-wrap gap-2">
             {value?.map((node) => (
               <Badge key={node.id} className="flex items-center gap-1 pr-0.5">
-                {node.identifier?.value}
+                {node.display_label}
 
                 <Button
                   size="icon"
@@ -140,13 +139,12 @@ export const PermissionComboboxList = forwardRef<HTMLDivElement, RelationshipCom
                       onSelect={() =>
                         onSelect({
                           id: node.id,
-                          display_label: node.identifier.value,
-                          identifier: { value: node.identifier.value },
+                          display_label: node.display_label,
                           __typename: node.__typename,
                         })
                       }
                     >
-                      <span className="truncate">{node.identifier.value}</span>
+                      <span className="truncate">{node.display_label}</span>
                     </ComboboxItem>
                   );
                 });

frontend/app/src/entities/role-manager/ui/roles.tsx

@@ -97,7 +97,7 @@ function Roles() {
           value: { edges: edge?.node?.permissions?.edges },
           display: (
             <InlineDisplay
-              items={edge?.node?.permissions?.edges?.map((edge) => edge?.node?.identifier?.value)}
+              items={edge?.node?.permissions?.edges?.map((edge) => edge?.node?.display_label)}
               render={(item) => <Badge>{item}</Badge>}
             />
           ),