reject blank username/password secrets for gcp

Author: MouhsinElmajdouby

ojdbc-provider-gcp/src/main/java/oracle/jdbc/provider/gcp/resource/GcpSecretManagerPasswordProvider.java

@@ -63,6 +63,11 @@ public GcpSecretManagerPasswordProvider() {
   public char[] getPassword(Map<Parameter, CharSequence> parameterValues) {
     ByteString secret = getSecret(parameterValues);
     String password = secret.toStringUtf8();
+
+    if (password == null || password.trim().isEmpty()) {
+      throw new IllegalArgumentException("Password secret content is blank.");
+    }
+
     return password.toCharArray();
   }
 

ojdbc-provider-gcp/src/main/java/oracle/jdbc/provider/gcp/resource/GcpSecretManagerUsernameProvider.java

@@ -60,7 +60,12 @@ public GcpSecretManagerUsernameProvider() {
 
   @Override
   public String getUsername(Map<Parameter, CharSequence> parameterValues) {
-    return getSecret(parameterValues).toStringUtf8();
+    String username = getSecret(parameterValues).toStringUtf8();
+
+    if (username == null || username.trim().isEmpty()) {
+      throw new IllegalArgumentException("Username secret content is blank");
+    }
+    return username;
   }
 
 }