Replies: 3 comments 4 replies
-
|
Hi Joost! This is a really good idea, I think the easiest thing todo would be add a module that defines units like Oceananigans does, but I have thought about using Unitful too. Maybe we should try and come up with a list of the units we'd like to put in then one of us can open a PR? |
Beta Was this translation helpful? Give feedback.
-
|
The only thing is we might need to be careful defining what an einstein is because I gather that it doesn't actually have a numerical definition and technically depends on the spectrum of light its referring to. In my projects I've used: const μE_s_to_W = 1 / 4.56from the daylight definition here: https://en.wikipedia.org/wiki/Photosynthetically_active_radiation |
Beta Was this translation helpful? Give feedback.
-
|
Do you think including aliases for things like concentrations would be useful? e.g.:
Adding semantic aliases for bookkeeping could also be an option |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
@jagoosw I would love to pick your brain on how to implement more explicit biogeochemical units in OceanBioME.jl
Oceananigans.jl has a nice Units module with syntax that could be extended for common biogeochemical units:
volume, concentration, fluxes, others? e.g. 1 / (W / m² / s), gC / dm² / s / einstein, 1 / dm² , etc.
Options could be to either suggest extending Oceananigans.Units to include relevant units like above, or to add something like OceanBioME.BGCUnits
An alternative is to rely on something like Unitful.jl and extensions like UnitfulMoles . The upside would be features like converting e.g. mol C to grams, but the downside might be unneeded complexity/ additional dependencies - so this seems like the less desirable option?
Happy to put a PR together as appropriate/ if of interest.
Beta Was this translation helpful? Give feedback.
All reactions