Have qspi take a slot argument (#585)

Hubris QSPI APIs target either flash slot 0 or flash slot 1. Currently
`humility qspi` uses the version of the API that targets the active
slot. This can be confusing if another command was run targeting the
inactive slot. Have `humility qspi` take a slot argument to change
the slot before running any commands.

Author: labbott

cmd/qspi/src/lib.rs

@@ -192,6 +192,10 @@ struct QspiArgs {
     /// persistently selects a storage slot
     #[clap(long, group = "command")]
     set_persistent_slot: Option<u8>,
+
+    /// Target a specific slot
+    #[clap(long)]
+    slot: Option<u8>,
 }
 
 struct QspiDevice {
@@ -485,6 +489,27 @@ fn qspi(context: &mut ExecutionContext) -> Result<()> {
     let subargs = QspiArgs::try_parse_from(subargs)?;
     let mut context = HiffyContext::new(hubris, core, subargs.timeout)?;
 
+    match subargs.slot {
+        None => humility::msg!("Using existing slot settings"),
+        s @ (Some(0) | Some(1)) => {
+            let s = s.unwrap();
+            humility::msg!("Setting slot to {s}");
+            let out = hiffy_call(
+                hubris,
+                core,
+                &mut context,
+                &hubris.get_idol_command("HostFlash.set_dev")?,
+                &[("dev", IdolArgument::String(&format!("Flash{s}")))],
+                None,
+                None,
+            )?;
+            if let Err(e) = out {
+                bail!("set_dev failed: {e}");
+            }
+        }
+        _ => bail!("Bad slot setting"),
+    }
+
     const SECTOR_SIZE: u32 = 64 * 1024;
     const BLOCK_SIZE: u32 = 256; // Conflating flash block size with hubris scratch buffer.