only explicit annotations args in records are on new lines

Author: crogoz

idea-plugin/build.gradle

@@ -22,7 +22,7 @@ intellij {
     pluginName = name
     updateSinceUntilBuild = true
     version = "2024.1"
-    plugins = ['java']
+    plugins = [ 'java' ]
 }
 
 patchPluginXml {

palantir-java-format/src/main/java/com/palantir/javaformat/java/JavaInputAstVisitor.java

@@ -2210,20 +2210,34 @@ protected List<Op> visitModifiers(
             ModifiersTree modifiersTree,
             Direction annotationsDirection,
             Optional<BreakTag> declarationAnnotationBreak) {
-        return visitModifiers(modifiersTree.getAnnotations(), annotationsDirection, declarationAnnotationBreak);
+        boolean isRecordParameter = false;
+        if (modifiersTree instanceof JCTree.JCModifiers) {
+            isRecordParameter = (((JCTree.JCModifiers) modifiersTree).flags & RECORD) == RECORD;
+        }
+        return visitModifiers(
+                modifiersTree.getAnnotations(), annotationsDirection, declarationAnnotationBreak, isRecordParameter);
     }
 
     private List<Op> visitModifiers(
             List<? extends AnnotationTree> annotationTrees,
             Direction annotationsDirection,
             Optional<BreakTag> declarationAnnotationBreak) {
+        return visitModifiers(annotationTrees, annotationsDirection, declarationAnnotationBreak, false);
+    }
+
+    private List<Op> visitModifiers(
+            List<? extends AnnotationTree> annotationTrees,
+            Direction annotationsDirection,
+            Optional<BreakTag> declarationAnnotationBreak,
+            boolean isRecordParameter) {
         if (annotationTrees.isEmpty() && !nextIsModifier()) {
             return EMPTY_LIST;
         }
         Deque<AnnotationTree> annotations = new ArrayDeque<>(annotationTrees);
         builder.open(ZERO);
         boolean first = true;
         boolean lastWasAnnotation = false;
+        boolean hasExplicitParameterizedAnnotation = false;
         while (!annotations.isEmpty()) {
             if (nextIsModifier()) {
                 break;
@@ -2234,14 +2248,22 @@ private List<Op> visitModifiers(
                                 ? forceBreakList(declarationAnnotationBreak)
                                 : breakList(declarationAnnotationBreak));
             }
-            scan(annotations.removeFirst(), null);
+            AnnotationTree annotation = annotations.removeFirst();
+            if (!annotation.getArguments().isEmpty()) {
+                ExpressionTree firstArg = annotation.getArguments().get(0);
+
+                // If it's an AssignmentTree, it's an explicit argument (name = value)
+                hasExplicitParameterizedAnnotation = firstArg instanceof AssignmentTree;
+            }
+            scan(annotation, null);
             first = false;
             lastWasAnnotation = true;
         }
         builder.close();
-        ImmutableList<Op> trailingBreak = annotationsDirection.isVertical()
-                ? forceBreakList(declarationAnnotationBreak)
-                : breakList(declarationAnnotationBreak);
+        ImmutableList<Op> trailingBreak =
+                annotationsDirection.isVertical() || (hasExplicitParameterizedAnnotation && isRecordParameter)
+                        ? forceBreakList(declarationAnnotationBreak)
+                        : breakList(declarationAnnotationBreak);
         if (annotations.isEmpty() && !nextIsModifier()) {
             return trailingBreak;
         }

palantir-java-format/src/test/resources/com/palantir/javaformat/java/testdata/AnnotationFields.input

@@ -22,10 +22,7 @@ public record QuoteRequest(
         @SomeInput
         @NotNull
         @Deprecated
-        @JsonValue(name = "something")
-        @Schema(description = "US state of the product being quoted", example = "TX")
-        RegulatoryState regulatoryState,
-
+        @JsonValue(name = "something") @Schema(description = "US state of the product being quoted", example = "TX") RegulatoryState regulatoryState,
         @Schema(description = "Reason for a quote", example = "New Business") String amendmentReason,
         int x,
         int j) {}
@@ -107,4 +104,27 @@ public record Url(
         int bla,
         @JsonValue("dadsa") String value) {}
 
-public record Url(@New @JsonValue("dadsa") String value) {}
+public record Url(@New @JsonValue("dadsa") String value) {}
+
+@JsonIgnoreProperties(ignoreUnknown = true)
+@JsonInclude(JsonInclude.Include.NON_NULL)
+public record Game(
+    @JsonProperty("accounting_group") @JsonPropertyDescription("The accounting group of the game.")
+        String accountingGroup,
+    @JsonProperty("accumulating")
+        @JsonPropertyDescription("Marks which games with accumulating bonuses.") Boolean accumulating,
+    @JsonProperty("bonus_buy") @JsonPropertyDescription("Games with purchasable bonuses.") Boolean bonusBuy,
+    @JsonProperty("category")
+        @JsonPropertyDescription(
+            "Game's category. Allowed values: slots, roulette, card, "
+                + "casual, lottery, poker, craps, video_poker")
+        String category,
+    @JsonProperty("hd") @JsonPropertyDescription("HD format games.") Boolean hd,
+
+    @JsonProperty("new") @JsonPropertyDescription("New format games.") Boolean assa,
+    @JsonProperty("hit_rate") @JsonPropertyDescription(
+            "Frequency of wins per 100 bets. The higher, the hit rate the lower the volatility "
+                + "rating, and vice versa. Positive value. For slots only. "
+                + "Match pattern: ^\\d{1,18}(\\.\\d{1,12})?$") String hitRate,
+    @JsonProperty("params") @JsonPropertyDescription("Game's custom parameters.")
+        Map<String, String> params) {}