AC-282: Fix deprecation messages for Symfony 6 (#16)

* AC-282: add void typehint

* AC-282: route loading error fix

* AC-282: extra check removed

* AC-282: remove Reader check

---------

Co-authored-by: Andrii Krasnoholovets <andrii.krasnoholovets@paysera.net>

Author: Okspen

.github/workflows/ci.yml

@@ -25,6 +25,7 @@ jobs:
           - '8.0'
           - '8.1'
           - '8.2'
+          - '8.3'
         symfony:
           - '3.*'
           - '4.*'
@@ -38,6 +39,7 @@ jobs:
           - { php: '8.0', symfony: '3.*' }
           - { php: '8.1', symfony: '3.*' }
           - { php: '8.2', symfony: '3.*' }
+          - { php: '8.3', symfony: '3.*' }
           - { php: '7.1', symfony: '5.*' }
           - { php: '7.1', symfony: '6.*' }
           - { php: '7.2', symfony: '6.*' }

CHANGELOG.md

@@ -4,6 +4,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.8.1]
+### Added
+- `void` typehint to `PayseraApiBundle::build` method to fix the deprecation message
+- PHP 8.3 to CI
+### Fixed
+- `Call to a member function getClassAnnotations() on null` error in `RoutingAttributeLoader` on Symfony 6
+
 ## [1.8.0]
 ### Added
 - Support for PHP 8 attributes

src/Listener/RestResponseListener.php

@@ -65,7 +65,7 @@ private function normalizeResult(Request $request, RestRequestOptions $options,
     {
         $includedFields = [];
         $fields = $request->query->get('fields');
-        if ($fields !== null && is_string($fields) && $fields !== '') {
+        if (is_string($fields) && $fields !== '') {
             $includedFields = explode(',', $fields);
         }
 

src/PayseraApiBundle.php

@@ -9,7 +9,7 @@
 
 class PayseraApiBundle extends Bundle
 {
-    public function build(ContainerBuilder $container)
+    public function build(ContainerBuilder $container): void
     {
         parent::build($container);
 

src/Service/RoutingLoader/RoutingAttributeLoader.php

@@ -61,6 +61,10 @@ protected function configureRoute(
 
     private function loadAnnotations(Route $route, ReflectionClass $class, ReflectionMethod $method): void
     {
+        if (!isset($this->reader)) {
+            return;
+        }
+
         $annotations = [];
         foreach ($this->reader->getClassAnnotations($class) as $annotation) {
             if ($annotation instanceof RestAnnotationInterface) {