Format Go code with go fmt ./...; check formatting in CI

Author: alexandear

.github/workflows/build.yaml

@@ -13,41 +13,46 @@ jobs:
     name: Build Windows
     runs-on: windows-latest
     steps:
+      - name: Force git to use LF
+        # This step is required on Windows to work around issues with go fmt.
+        # TODO: replace with a checkout option when https://github.com/actions/checkout/issues/226 is implemented
+        run: |
+          git config --global core.autocrlf false
+          git config --global core.eol lf
+
+      - name: Checkout code
+        uses: actions/checkout@v6
+
       - name: Set up Go 1.x
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v6
         with:
           go-version: 1.23
         id: go
 
-      - name: Checkout code
-        uses: actions/checkout@v3
-
-      - name: Get dependencies
+      - name: Format
         run: |
-          go get -v -t -d ./...
+          go fmt ./...
+          git diff --exit-code
       - name: Test
         run: go test ./...
   build:
     name: Build Linux
     runs-on: ubuntu-latest
 
     steps:
+      - name: Checkout code
+        uses: actions/checkout@v6
+
       - name: Set up Go 1.x
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v6
         with:
           go-version: 1.23
         id: go
 
-      - name: Checkout code
-        uses: actions/checkout@v3
-
-      - name: Get dependencies
+      - name: Format
         run: |
-          go get -v -t -d ./...
-          if [ -f Gopkg.toml ]; then
-              curl https://raw.githubusercontent.com/golang/dep/master/install.sh | sh
-              dep ensure
-          fi
+          go fmt ./...
+          git diff --exit-code
       - name: Test
         run: go test ./...
       - name: Coverage

bundler/bundler_test.go

@@ -2319,8 +2319,8 @@ func TestCopySchemaToComponents_NameCollision(t *testing.T) {
 func TestCalculateCollisionNameInline_NumericSuffix(t *testing.T) {
 	// Test: When filename-based name also collides, use numeric suffix
 	existingNames := map[string]bool{
-		"Cat":             true,
-		"Cat__external":   true, // Filename-based collision also exists
+		"Cat":              true,
+		"Cat__external":    true, // Filename-based collision also exists
 		"Cat__external__1": true, // First numeric suffix also taken (format: name__basename__N)
 	}
 

bundler/origin_test.go

@@ -914,7 +914,7 @@ func TestCaptureOrigin_FullCoverage(t *testing.T) {
 		pr := &processRef{
 			ref: &index.Reference{
 				FullDefinition: "test.yaml",
-				Node: &yaml.Node{Line: 5, Column: 2},
+				Node:           &yaml.Node{Line: 5, Column: 2},
 			},
 			idx:          &index.SpecIndex{},
 			originalName: "Test",

datamodel/high/base/dynamic_value.go

@@ -22,11 +22,11 @@ import (
 //
 // The N value indicates which value is set (0 = A, 1 == B), preventing the need to check both values.
 type DynamicValue[A any, B any] struct {
-	N           int // 0 == A, 1 == B
-	A           A
-	B           B
-	inline      bool
-	renderCtx   any // Context for inline rendering (typed as any to avoid import cycles)
+	N         int // 0 == A, 1 == B
+	A         A
+	B         B
+	inline    bool
+	renderCtx any // Context for inline rendering (typed as any to avoid import cycles)
 }
 
 // IsA will return true if the 'A' or left value is set.

datamodel/high/overlay/action.go

@@ -13,11 +13,11 @@ import (
 // Action represents a high-level Overlay Action Object.
 // https://spec.openapis.org/overlay/v1.1.0#action-object
 type Action struct {
-	Target      string                               `json:"target,omitempty" yaml:"target,omitempty"`
-	Description string                               `json:"description,omitempty" yaml:"description,omitempty"`
-	Update      *yaml.Node                           `json:"update,omitempty" yaml:"update,omitempty"`
-	Remove      bool                                 `json:"remove,omitempty" yaml:"remove,omitempty"`
-	Copy        string                               `json:"copy,omitempty" yaml:"copy,omitempty"`
+	Target      string                              `json:"target,omitempty" yaml:"target,omitempty"`
+	Description string                              `json:"description,omitempty" yaml:"description,omitempty"`
+	Update      *yaml.Node                          `json:"update,omitempty" yaml:"update,omitempty"`
+	Remove      bool                                `json:"remove,omitempty" yaml:"remove,omitempty"`
+	Copy        string                              `json:"copy,omitempty" yaml:"copy,omitempty"`
 	Extensions  *orderedmap.Map[string, *yaml.Node] `json:"-" yaml:"-"`
 	low         *low.Action
 }

datamodel/high/overlay/info.go

@@ -13,9 +13,9 @@ import (
 // Info represents a high-level Overlay Info Object.
 // https://spec.openapis.org/overlay/v1.1.0#info-object
 type Info struct {
-	Title       string                               `json:"title,omitempty" yaml:"title,omitempty"`
-	Version     string                               `json:"version,omitempty" yaml:"version,omitempty"`
-	Description string                               `json:"description,omitempty" yaml:"description,omitempty"`
+	Title       string                              `json:"title,omitempty" yaml:"title,omitempty"`
+	Version     string                              `json:"version,omitempty" yaml:"version,omitempty"`
+	Description string                              `json:"description,omitempty" yaml:"description,omitempty"`
 	Extensions  *orderedmap.Map[string, *yaml.Node] `json:"-" yaml:"-"`
 	low         *low.Info
 }

datamodel/high/overlay/overlay.go

@@ -13,10 +13,10 @@ import (
 // Overlay represents a high-level OpenAPI Overlay document.
 // https://spec.openapis.org/overlay/v1.0.0
 type Overlay struct {
-	Overlay    string                               `json:"overlay,omitempty" yaml:"overlay,omitempty"`
-	Info       *Info                                `json:"info,omitempty" yaml:"info,omitempty"`
-	Extends    string                               `json:"extends,omitempty" yaml:"extends,omitempty"`
-	Actions    []*Action                            `json:"actions,omitempty" yaml:"actions,omitempty"`
+	Overlay    string                              `json:"overlay,omitempty" yaml:"overlay,omitempty"`
+	Info       *Info                               `json:"info,omitempty" yaml:"info,omitempty"`
+	Extends    string                              `json:"extends,omitempty" yaml:"extends,omitempty"`
+	Actions    []*Action                           `json:"actions,omitempty" yaml:"actions,omitempty"`
 	Extensions *orderedmap.Map[string, *yaml.Node] `json:"-" yaml:"-"`
 	low        *low.Overlay
 }

datamodel/high/v3/request_body_test.go

@@ -320,4 +320,3 @@ paths: {}`
 	assert.NoError(t, err)
 	assert.NotNil(t, result)
 }
-

datamodel/high/v3/security_scheme_test.go

@@ -157,7 +157,6 @@ func TestSecurityScheme_MarshalYAMLInlineWithContext_Reference(t *testing.T) {
 	assert.Equal(t, "$ref", yamlNode.Content[0].Value)
 }
 
-
 func TestBuildLowSecurityScheme_Success(t *testing.T) {
 	yml := `type: apiKey
 name: X-API-Key

datamodel/high/v3/server.go

@@ -14,7 +14,7 @@ import (
 // Server represents a high-level OpenAPI 3+ Server object, that is backed by a low level one.
 //   - https://spec.openapis.org/oas/v3.1.0#server-object
 type Server struct {
-	Name        string                                   `json:"name,omitempty" yaml:"name,omitempty"`         // OpenAPI 3.2+ name field for documentation
+	Name        string                                   `json:"name,omitempty" yaml:"name,omitempty"` // OpenAPI 3.2+ name field for documentation
 	URL         string                                   `json:"url,omitempty" yaml:"url,omitempty"`
 	Description string                                   `json:"description,omitempty" yaml:"description,omitempty"`
 	Variables   *orderedmap.Map[string, *ServerVariable] `json:"variables,omitempty" yaml:"variables,omitempty"`