Skip to content

Commit f9015c0

Browse files
authored
fix: confusing tls connection indicator (#747)
Currently, the log uses `🔓` to indicate a TLS connection, which is confusing. Since the lock in this icon is open, it appears inconsistent with the expression of security. To convey security, using a locked lock icon `🔒` seems more appropriate. One piece of evidence is that the code in https://github.com/pgdogdev/pgdog/blob/9afa9f6e126a7ac802aaf0a3d233d5d6221456cf/pgdog/src/net/tls.rs#L127 uses `🔓` to indicate TLS is disabled. Regarding whether to use `🔓` as an indicator for non-TLS connections, I welcome further input.
1 parent fabf5ec commit f9015c0

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

pgdog/src/backend/server.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ impl Server {
250250
addr,
251251
auth_type,
252252
connect_reason,
253-
if stream.is_tls() { "🔓" } else { "" },
253+
if stream.is_tls() { "🔒" } else { "" },
254254
);
255255

256256
let mut server = Server {

pgdog/src/frontend/client/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ impl Client {
294294
} else {
295295
auth_type.to_string()
296296
},
297-
if stream.is_tls() { "🔓" } else { "" }
297+
if stream.is_tls() { "🔒" } else { "" }
298298
);
299299
}
300300

0 commit comments

Comments
 (0)