Skip to content

Commit fbf79f1

Browse files
fix 8.3 failures
1 parent 878aa86 commit fbf79f1

File tree

2 files changed

+2
-32
lines changed

2 files changed

+2
-32
lines changed

internal/extgen/gofile_test.go

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import (
66
"encoding/hex"
77
"os"
88
"path/filepath"
9-
"strings"
109
"testing"
1110

1211
"github.com/stretchr/testify/assert"
@@ -1238,26 +1237,6 @@ func TestGoFileGenerator_phpTypeToGoType(t *testing.T) {
12381237
})
12391238
}
12401239

1241-
func testGoFileInternalFunctions(t *testing.T, content string) {
1242-
internalIndicators := []string{
1243-
"func internalHelper",
1244-
"func anotherHelper",
1245-
}
1246-
1247-
foundInternal := false
1248-
for _, indicator := range internalIndicators {
1249-
if strings.Contains(content, indicator) {
1250-
foundInternal = true
1251-
1252-
break
1253-
}
1254-
}
1255-
1256-
if !foundInternal {
1257-
t.Log("No internal functions found (this may be expected)")
1258-
}
1259-
}
1260-
12611240
func testGeneratedFileBasicStructure(t *testing.T, content, expectedPackage, baseName string) {
12621241
requiredElements := []string{
12631242
"package " + expectedPackage,
@@ -1292,15 +1271,6 @@ func testGeneratedFileWrappers(t *testing.T, content string, functions []phpFunc
12921271
}
12931272
}
12941273

1295-
// compareFileContents compares two files byte-by-byte
1296-
func compareFileContents(t *testing.T, file1, file2 string) bool {
1297-
content1, err := os.ReadFile(file1)
1298-
require.NoError(t, err)
1299-
content2, err := os.ReadFile(file2)
1300-
require.NoError(t, err)
1301-
return bytes.Equal(content1, content2)
1302-
}
1303-
13041274
// computeFileHash returns SHA256 hash of file
13051275
func computeFileHash(t *testing.T, filename string) string {
13061276
content, err := os.ReadFile(filename)

internal/extgen/templates/stub.php.tpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22

3+
/** @generate-class-entries */
4+
35
// AUTOGENERATED FILE - DO NOT EDIT.
46
//
57
// This file has been automatically generated by FrankenPHP extension generator
@@ -8,8 +10,6 @@
810
//
911
// You may edit the file and remove this comment if you plan to manually maintain
1012
// this file going forward.
11-
12-
/** @generate-class-entries */
1313
{{if .Namespace}}
1414
namespace {{.Namespace}};
1515
{{end}}

0 commit comments

Comments
 (0)