Skip to content

Commit 91e7957

Browse files
authored
fix: replace setHeaders function with optimized inline header setting (#74)
1 parent 59a45ca commit 91e7957

File tree

2 files changed

+4
-21
lines changed

2 files changed

+4
-21
lines changed

HISTORY.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ unreleased
1212
* remove unnecessary devDependency `readable-stream`
1313
* refactor: use object spread to copy error headers
1414
* refactor: use replaceAll instead of replace with a regex
15+
* refactor: replace setHeaders function with optimized inline header setting
1516

1617
v2.0.0 / 2024-09-02
1718
==================

index.js

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,9 @@ function send (req, res, status, headers, message) {
259259
res.removeHeader('Content-Range')
260260

261261
// response headers
262-
setHeaders(res, headers)
262+
for (const [key, value] of Object.entries(headers ?? {})) {
263+
res.setHeader(key, value)
264+
}
263265

264266
// security headers
265267
res.setHeader('Content-Security-Policy', "default-src 'none'")
@@ -289,23 +291,3 @@ function send (req, res, status, headers, message) {
289291
onFinished(req, write)
290292
req.resume()
291293
}
292-
293-
/**
294-
* Set response headers from an object.
295-
*
296-
* @param {OutgoingMessage} res
297-
* @param {object} headers
298-
* @private
299-
*/
300-
301-
function setHeaders (res, headers) {
302-
if (!headers) {
303-
return
304-
}
305-
306-
var keys = Object.keys(headers)
307-
for (var i = 0; i < keys.length; i++) {
308-
var key = keys[i]
309-
res.setHeader(key, headers[key])
310-
}
311-
}

0 commit comments

Comments
 (0)