[System Settings] Add additional system settings to provider#1644
Open
[System Settings] Add additional system settings to provider#1644
Conversation
|
Corepex
commented
Feb 6, 2026
| 'documents' => $this->systemSettings['documents'] ?? [], | ||
| 'objects' => $this->systemSettings['objects'] ?? [], | ||
| 'assets' => $this->systemSettings['assets'] ?? [], | ||
| 'errorPages' => $this->systemSettings['error_pages'] ?? [], |
Contributor
Author
There was a problem hiding this comment.
@mcop1, please return all relation-related elements as RelatedElementData to have the same data structure everywhere. This should be documents.error_pages.default and documents.error_pages.localized.<locale>
Corepex
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Additional info
This pull request expands the settings returned by the
getSettings()method inSystemSettingsProvider.phpto include additional system configuration options. The new settings provide more comprehensive access to various system features such as documents, objects, assets, error pages, domain redirection, and email configuration.Additional system settings exposed:
documents,objects, andassetskeys to the settings array, allowing access to their respective system configurations.errorPageskey for error page configuration.redirectToMainDomainkey for main domain redirection settings.emailkey for email-related system settings.