Skip to content

Commit 0251716

Browse files
emilyklcamdecoster
andauthored
Apply suggestions from code review
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
1 parent 7d71516 commit 0251716

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

src/plots/cartesian/dragbox.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -733,7 +733,7 @@ function makeDragBox(gd, plotinfo, x, y, w, h, ns, ew) {
733733
var axListI = axList[i];
734734
var axListIType = axListI[axisType];
735735
var axId = axListIType._id;
736-
if(!axListI.fixedrange && axListIType.tickmode === 'sync' && activeAxIds.indexOf(axId) === -1) {
736+
if(!axListI.fixedrange && axListIType.tickmode === 'sync' && !activeAxIds.includes(axId)) {
737737
activeAxIds.push(axId);
738738
}
739739
}

src/plots/cartesian/layout_attributes.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ var tickmode = extendFlat({}, minorTickmode, {
3636
minorTickmode.description,
3737
'If *sync*, the number of ticks will sync with the overlayed axis',
3838
'set by `overlaying` property. When no other tick info is provided,',
39-
'overlyaing (non-categorical) axes default to *sync*, while other axes default to *auto*.',
39+
'overlaying (non-categorical) axes default to *sync*, while other axes default to *auto*.',
4040
].join(' ')
4141
});
4242

src/plots/cartesian/tick_value_defaults.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ var isArrayOrTypedArray = require('../../lib').isArrayOrTypedArray;
55
var isTypedArraySpec = require('../../lib/array').isTypedArraySpec;
66
var decodeTypedArraySpec = require('../../lib/array').decodeTypedArraySpec;
77

8-
module.exports = function handleTickValueDefaults(containerIn, containerOut, coerce, axType, opts) {
8+
module.exports = function handleTickValueDefaults(containerIn, containerOut, coerce, axType, opts = {}) {
99
if (!opts) opts = {};
1010
var isMinor = opts.isMinor;
1111
var cIn = isMinor ? containerIn.minor || {} : containerIn;

0 commit comments

Comments
 (0)