[Bug] Failure to Preserve gitlab-secrets.json Across Builds

[ferricoxide]

Describe the bug

Deployment-automation currently does not attempt to preserve the gitlab-secrets.json across instantiations. When users store secrets for CI-automation or other integrations, this will cause CI jobs to fail and the projects' Integrations tab/page to become unloadable (HTTP 500 errors).

Severity

• Completely Broken (No work-around evident)
• Severely Broken (Work-around possible but difficult)
• Moderately Broken (Trivial work-around)
• Nuisance (Functions but untrapped errors can slip through)

To Reproduce

Steps to reproduce the behavior:

1. Launch new GitLab domain
2. Allow users to create CI-jobs or other integrations that use stored secrets
3. Migrate service to new node (version, OS or other related task that redeploys the service to new instance)
4. Attempt to run CI-jobs or other integrations that use stored secrets — failures should be present

Expected behavior

Node-replacing upgrades to not adversely impact service-functionality.

Additional context

Problem matches what's described in the vendor documentation.

Fix Suggestions

Add a launch-time task to check if a gitlab-secrets.json file has been stored to a safe location:

• If yes, download to new instance's /etc/gitlab directory
• If no, treat as new installation and save new gitlab-secrets.json file to a safe location