Skip to content

Commit e14555e

Browse files
committed
Add link to known-issues.md in readme
1 parent e4fb976 commit e14555e

File tree

2 files changed

+52
-23
lines changed

2 files changed

+52
-23
lines changed

README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,10 @@ If you encounter the error "Apple could not verify this app is free of malware",
169169

170170
</details>
171171

172+
## Common issues
173+
174+
Before opening a new issue, please check the [Known Issues](docs/known-issues.md) document for common issues and their workarounds.
175+
172176
## Running the app locally
173177

174178
### From the terminal

docs/known-issues.md

Lines changed: 48 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# Table of contents
22

33
- [macOS](#macos)
4+
- ['Apple could not verify this app is free of malware' error when launching the app](#apple-could-not-verify-this-app-is-free-of-malware-error-when-launching-the-app)
45
- ['The username or passphrase you entered is not correct' error after signing into account](#the-username-or-passphrase-you-entered-is-not-correct-error-after-signing-into-account)
56
- [Checking for updates triggers a 'Could not create temporary directory: Permission denied' message](#checking-for-updates-triggers-a-could-not-create-temporary-directory-permission-denied-message)
67
- [Windows](#windows)
@@ -12,8 +13,10 @@
1213
- [Failed to open CA file after an update](#failed-to-open-ca-file-after-an-update)
1314
- [Authentication errors due to modified registry entries](#authentication-errors-due-to-modified-registry-entries)
1415
- [Linux](#linux)
15-
- [I get a white screen when launching Desktop](#i-get-a-white-screen-when-launching-desktop)
16+
- [I cannot sign in using "Continue with browser"](#i-cannot-sign-in-using-continue-with-browser)
17+
- [Error "cannot read property 'path' of undefined"](#my-shellterminal-is-not-detected-and-is-stuck-on-gnome-terminal)
1618
- [I cannot access repositories under my organization](#i-cannot-access-repositories-under-my-organization)
19+
- [I get a white screen when launching Desktop](#i-get-a-white-screen-when-launching-desktop)
1720
- [My shell/terminal is not detected and is stuck on "GNOME Terminal"](#my-shellterminal-is-not-detected-and-is-stuck-on-gnome-terminal)
1821

1922
# Known Issues
@@ -32,10 +35,18 @@ Each known issue links off to an existing GitHub issue. If you have additional q
3235

3336
### My issue is not listed here?
3437

35-
Please check the [open](https://github.com/desktop/desktop/labels/bug) and [closed](https://github.com/desktop/desktop/issues?q=is%3Aclosed+label%3Abug) bugs in the issue tracker for the details of your bug. If you can't find it, or if you're not sure, open a [new issue](https://github.com/desktop/desktop/issues/new?template=bug_report.md).
38+
Please check the [open](https://github.com/pol-rivero/github-desktop-plus/issues) and [closed](https://github.com/pol-rivero/github-desktop-plus/issues?q=is%3Aissue%20state%3Aclosed) bugs in the issue tracker for the details of your bug. If you can't find it, or if you're not sure, open a [new issue](https://github.com/pol-rivero/github-desktop-plus/issues/new?template=bug_report.yaml).
3639

3740
## macOS
3841

42+
### 'Apple could not verify this app is free of malware' error when launching the app
43+
44+
Related issue: [#33](https://github.com/pol-rivero/github-desktop-plus/issues/33)
45+
46+
This error is caused by the app not being notarized by Apple, as notarization requires a paid Apple Developer account.
47+
48+
Simply go to "System Settings" > "Privacy & Security", scroll down to "Security" and click "Open Anyway" on "GitHub Desktop Plus".
49+
3950
### 'The username or passphrase you entered is not correct' error after signing into account
4051

4152
Related issue: [#3263](https://github.com/desktop/desktop/issues/3263)
@@ -232,29 +243,30 @@ If you see an error that says "Not enough resources are available to process thi
232243

233244
## Linux
234245

235-
### The PackageCloud package feed is no longer working
246+
### I cannot sign in using "Continue with browser"
236247

237-
The PackageCloud feed has been closed down. If you are seeing errors about this you should remove the configuration for this feed and refer to the [README](https://github.com/shiftkey/desktop#repositories)
238-
for the new settings.
248+
Related issue: [#54](https://github.com/pol-rivero/github-desktop-plus/issues/54)
239249

240-
#### APT configuration
250+
After following the instructions in your web browser to authorize GitHub Desktop, the callback is not sent to the app and it remains stuck on the "Continue with browser" screen.
241251

242-
```
243-
sudo rm /etc/apt/trusted.gpg.d/shiftkey-desktop.asc
244-
sudo rm /etc/apt/sources.list.d/packagecloud-shiftkey-desktop.list
245-
```
246-
247-
#### RPM configuration
252+
The most likely cause is that the URI scheme used by GitHub Desktop Plus for authorization (`x-github-desktop-auth://`) is not linked to the correct program. You can verify if this is the case by fully closing GitHub Desktop Plus (`Ctrl+Q`) and running the following command in your terminal:
248253

249-
```
250-
sudo rm /etc/apt/sources.list.d/packagecloud-shiftkey-desktop.list
254+
```bash
255+
xdg-open "x-github-desktop-auth://test"
251256
```
252257

253-
### I get a white screen when launching Desktop
258+
This should open the GitHub Desktop Plus app. If it doesn't, it means the URI scheme is not linked to the app, and you can fix it by running the following command:
254259

255-
Electron enables hardware accelerated graphics by default, but some graphics cards have issues with hardware acceleration which means the application will launch successfully but it will be a white screen. If you are running GitHub Desktop within virtualization software like Parallels Desktop, hardware accelerated graphics may not be available.
260+
```bash
261+
# Prints the current default app for the URI scheme
262+
xdg-mime query default x-scheme-handler/x-github-desktop-auth
256263

257-
**Workaround:** if you set the `GITHUB_DESKTOP_DISABLE_HARDWARE_ACCELERATION` environment variable to any value and launch Desktop again it will disable hardware acceleration on launch, so the application is usable.
264+
# Set GitHub Desktop Plus as the default app for the URI scheme
265+
xdg-mime default github-desktop-plus.desktop x-scheme-handler/x-github-desktop-auth
266+
267+
# Alternatively, if you are using the flatpak:
268+
xdg-mime default io.github.pol_rivero.github-desktop-plus.desktop x-scheme-handler/x-github-desktop-auth
269+
```
258270

259271
### I cannot access repositories under my organization
260272

@@ -267,13 +279,23 @@ in a couple of different ways:
267279
generic error message
268280

269281
The root cause of this is organizations by default will have "OAuth App access
270-
restrictions" enabled, which blocks the GitHub Desktop development app that is
282+
restrictions" enabled, which blocks the GitHub Desktop Plus app that is
271283
used by this fork.
272284

285+
You can verify if this is the case by going to https://github.com/settings/applications, clicking on "Desktop Plus (GitHub Desktop Plus)", and checking if your organization is enabled in the "Organization access" section.
286+
273287
**Workaround:** ask your organization admin to [approve access](https://docs.github.com/en/organizations/restricting-access-to-your-organizations-data/approving-oauth-apps-for-your-organization)
274-
to the GitHub Desktop development app.
288+
to the GitHub Desktop Plus app.
289+
290+
If you have not requested the GitHub Desktop Plus app for this organization, [follow these instructions first](https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-your-membership-in-organizations/requesting-organization-approval-for-oauth-apps).
291+
292+
293+
### I get a white screen when launching Desktop
294+
295+
Electron enables hardware accelerated graphics by default, but some graphics cards have issues with hardware acceleration which means the application will launch successfully but it will be a white screen. If you are running GitHub Desktop within virtualization software like Parallels Desktop, hardware accelerated graphics may not be available.
296+
297+
**Workaround:** if you set the `GITHUB_DESKTOP_DISABLE_HARDWARE_ACCELERATION` environment variable to any value and launch Desktop again it will disable hardware acceleration on launch, so the application is usable.
275298

276-
If you have not requested the GitHub Desktop development app for this organization, [follow these instructions first](https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-your-membership-in-organizations/requesting-organization-approval-for-oauth-apps).
277299

278300
### My shell/terminal is not detected and is stuck on GNOME Terminal
279301

@@ -283,7 +305,10 @@ environment's shell, despite the shell being selected in the application setting
283305
Attempting to launch the shell from the application will show the error
284306
"cannot read property 'path' of undefined".
285307

286-
**Workarounds:**
308+
**Workaround:**
287309

288-
- Option 1: install a second different terminal, switch to it, then switch to the terminal you want to use, and then uninstall the second terminal.
289-
- Option 2: open the application's developer tools and step through the JS calls to correctly set the shell. Further details at https://github.com/shiftkey/desktop/issues/344#issuecomment-1001287110
310+
1. Install any other terminal emulator (it doesn't matter which one).
311+
1. In GitHub Desktop Plus, go to "File" > "Options" > "Integrations".
312+
1. Change the "Shell" option to the other terminal emulator you have installed. Click "Save".
313+
1. Change the "Shell" option back to your preferred terminal emulator. Click "Save" again.
314+
1. Uninstall the other terminal emulator you installed in step 1, you no longer need it.

0 commit comments

Comments
 (0)