`filter` no longer matches `architecture:arm64`, starting in beta8

[chrisant996]

What seems to be the problem?
targetsuffix is no longer respected for ARM64, starting in beta8.
It was working fine for me in beta2 through beta7.
I've been using premake for ARM64 on Windows for years (cross-compiling and publishing generated ARM64 builds).

What did you expect to happen?
The <TargetName> should include the targetsuffix, but for ARM64 it no longer does.
I expected ARM64 to respect the targetsuffix as it did in beta2 through beta7.
In beta8 x86 and x64 include the suffix, but ARM64 does not.

What have you tried so far?

1. I bisected which version of premake introduced this problem: beta2 through beta7 respect targetsuffix for ARM64, but beta8 does not -- the regression was introduced in beta8.
2. I'm working on finding a way to work around this beta8 regression.
3. I may also track down what commit introduced the regression, after I find a workaround (or give up on finding a workaround).

How can we reproduce this?
Use the following premake5.lua file, run premake5 vs2022, and then observe the <TargetName> fields in the resulting repro.vcxproj file.

workspace("repro")
    configurations({"debug", "release", "final"})
    platforms({"x86", "x64", "arm64"})

project("repro")
    kind("consoleapp")

    filter {cfg, "architecture:x86"}
        targetsuffix("_x86")

    filter {cfg, "architecture:x64"}
        targetsuffix("_x64")

    filter {cfg, "architecture:arm64"}
        targetsuffix("_arm64")

• Visual Studio 2022 (vs2022)
• I haven't tried any other versions of VS yet, but since VS is not even being invoked it seems unlikely to be related to the VS version.

What version of Premake are you using?

> premake5 --version
premake5 (Premake Build Script Generator) 5.0.0-beta8

[chrisant996]

The problem seems to be that filter {cfg, "architecture:arm64"} no longer works.

However, filter {cfg, "architecture:aarch64"} works.

The documentation for architecture says that ARM64 is an alias for AARCH64.

• filter matches architecture:aarch64 for ARM64.
• filter does not match architecture:arm64 for ARM64.

[nickclark2016]

Looks like our filter alias for architecture is case sensitive. ARM64 should still work, but I don't think arm64 will. @samsinsane thoughts on allowing some types of filters to be case-insensitive, such as architecture or configuration?

[chrisant996]

Looks like our filter alias for architecture is case sensitive. ARM64 should still work, but I don't think arm64 will. @samsinsane thoughts on allowing some types of filters to be case-insensitive, such as architecture or configuration?

I don't think it's a case sensitivity issue (and it was working as lowercase arm64 from beta2 through beta7).

• aarch64 works
• AARCH64 works
• arm64 does not work
• ARM64 does not work

It looks like commit 0fb6ba2 is probably the point at which the regression was introduced.

Edit: But I don't see any obvious way that commit could have introduced this, so maybe it's either a different commit (possibly not actually directly related to arm64) or exposing a pre-existing issue somewhere else.

Edit 2: I bisected the source changes, and 0fb6ba2 is indeed the one where the behavior changes.

[nickclark2016]

Hmm, looks like aliases aren't being picked up at all in the filter. That's definitely a bit weird. I'll look into it.

Edit: No, that wouldn't make sense, given x64 is an alias. This is definitely a bit tricky.

[chrisant996]

Using "aarch64" is a viable workaround for now.

Ideally I would like to use "arm64" because it's more clear, at least in the Windows world that I inhabit: I've never heard of "AARCH64" before and everyone has always used "ARM64", so it would be nice for the premake5.lua file to be able to continue to use familiar terms.

[chrisant996]

I bisected the changes, and commit 0fb6ba2 is indeed the one that changes the behavior.